ahill/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-01-26 14:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

app: Don't use polkit agent in history command

Browse Source 
There's no need to use polkit in the history command, so don't start the
agent in flatpak-main.c. This means we can avoid a test failure in
test-history.sh which was caused by old versions of valgrind being
unaware of syscall sched_getattr, which is used in g_bus_get_sync(),
itself called by install_polkit_agent().

(cherry picked from commit dd9fe190661bce70adf4e3df972b8033a656d48a)
This commit is contained in:
Phaedrus Leeds 2021-11-17 10:33:15 -08:00 committed by Phaedrus Leeds
parent 3e1f661654
commit 0a4491aed7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/flatpak-main.c
View File

@ -817,10 +817,11 @@ flatpak_run (int argc,
check_environment ();
/* Don't talk to dbus in enter, as it must be thread-free to setns, also
skip run/build for performance reasons (no need to connect to dbus). */
skip run/build/history for performance reasons (no need to connect to dbus). */
if (g_strcmp0 (command->name, "enter") != 0 &&
g_strcmp0 (command->name, "run") != 0 &&
g_strcmp0 (command->name, "build") != 0)
g_strcmp0 (command->name, "build") != 0 &&
g_strcmp0 (command->name, "history") != 0)
polkit_agent = install_polkit_agent ();
/* g_vfs_get_default can spawn threads */