ahill/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-01-26 14:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

session-helper: Validate HostCommand arguments

Browse Source 
This is not a portal, but we should still do some
due diligence.

Closes: #2365
Approved by: alexlarsson
This commit is contained in:
Matthias Clasen 2018-11-30 20:31:39 -05:00 committed by Atomic Bot
parent f3f7417b16
commit 972804f222
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
session-helper/flatpak-session-helper.c
View File

@ -235,6 +235,16 @@ handle_host_command (FlatpakDevelopment *object,
return TRUE;
}
if (!g_variant_is_of_type (arg_fds, G_VARIANT_TYPE ("a{uh}")) ||
!g_variant_is_of_type (arg_envs, G_VARIANT_TYPE ("a{ss}")) ||
(flags & ~FLATPAK_HOST_COMMAND_FLAGS_CLEAR_ENV) != 0)
{
g_dbus_method_invocation_return_error (invocation, G_DBUS_ERROR,
G_DBUS_ERROR_INVALID_ARGS,
"Unexpected argument");
return TRUE;
}
g_debug ("Running host command %s", arg_argv[0]);
n_fds = 0;