ahill/flatpak
1
0
Fork 0
mirror of https://github.com/flatpak/flatpak.git synced 2026-01-26 14:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

portal: Fix potential leak of data buffer in error cases

Browse Source 
Closes #4233
This commit is contained in:
Chris Williams 2025-01-28 23:53:18 -05:00 committed by Sebastian Wick
parent 947d4a6ce4
commit b343107c55
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
portal/flatpak-portal.c
View File

@ -2719,6 +2719,7 @@ read_variant (GInputStream *in,
GError **error)
{
guint32 size;
g_autofree guchar *data_owned = NULL;
guchar *data;
gsize bytes_read;
@ -2732,7 +2733,8 @@ read_variant (GInputStream *in,
return NULL;
}
data = g_try_malloc (size);
data_owned = g_try_malloc (size);
data = data_owned;
if (data == NULL)
{
flatpak_fail (error, "Out of memory");
@ -2750,7 +2752,9 @@ read_variant (GInputStream *in,
}
return g_variant_ref_sink (g_variant_new_from_data (G_VARIANT_TYPE("(uuuuss)"),
data, size, FALSE, g_free, data));
data, size, FALSE,
g_free,
g_steal_pointer (&data_owned)));
}
/* We do the actual update out of process (in do_update_child_process,