From bda7575e79b7b3f7edd320ad66e8c6037e334d85 Mon Sep 17 00:00:00 2001
From: Alexander Larsson <alexl@redhat.com>
Date: Fri, 19 May 2017 14:32:11 +0200
Subject: [PATCH] Add version property to all dbus interfaces

---
 data/org.freedesktop.Flatpak.xml                     | 4 ++++
 data/org.freedesktop.impl.portal.PermissionStore.xml | 1 +
 data/org.freedesktop.portal.Documents.xml            | 1 +
 document-portal/xdp-main.c                           | 2 ++
 permission-store/xdg-permission-store.c              | 2 ++
 session-helper/flatpak-session-helper.c              | 4 ++++
 system-helper/flatpak-system-helper.c                | 2 ++
 7 files changed, 16 insertions(+)

diff --git a/data/org.freedesktop.Flatpak.xml b/data/org.freedesktop.Flatpak.xml
index ae79605e..7136024c 100644
--- a/data/org.freedesktop.Flatpak.xml
+++ b/data/org.freedesktop.Flatpak.xml
@@ -25,6 +25,7 @@
 
 <node name="/" xmlns:doc="http://www.freedesktop.org/dbus/1.0/doc.dtd">
   <interface name='org.freedesktop.Flatpak.SessionHelper'>
+    <property name="version" type="u" access="read"/>
 
     <method name="RequestMonitor">
       <arg type='ay' name='path' direction='out'/>
@@ -32,6 +33,7 @@
   </interface>
 
   <interface name='org.freedesktop.Flatpak.Development'>
+    <property name="version" type="u" access="read"/>
 
     <!-- This methods let you start processes, sandboxed or not on the
          host, so its not generally safe to allow access to it to any
@@ -59,6 +61,8 @@
   </interface>
 
   <interface name='org.freedesktop.Flatpak.SystemHelper'>
+    <property name="version" type="u" access="read"/>
+
     <method name="Deploy">
       <arg type='ay' name='repo_path' direction='in'/>
       <arg type='u' name='flags' direction='in'/>
diff --git a/data/org.freedesktop.impl.portal.PermissionStore.xml b/data/org.freedesktop.impl.portal.PermissionStore.xml
index a4ff30c9..0e59e386 100644
--- a/data/org.freedesktop.impl.portal.PermissionStore.xml
+++ b/data/org.freedesktop.impl.portal.PermissionStore.xml
@@ -42,6 +42,7 @@
       (in the form of a GVariant) with each resource.
   -->
   <interface name='org.freedesktop.impl.portal.PermissionStore'>
+    <property name="version" type="u" access="read"/>
 
     <!--
         Lookup:
diff --git a/data/org.freedesktop.portal.Documents.xml b/data/org.freedesktop.portal.Documents.xml
index c1e82112..148e33d7 100644
--- a/data/org.freedesktop.portal.Documents.xml
+++ b/data/org.freedesktop.portal.Documents.xml
@@ -47,6 +47,7 @@
       in the POSIX mode bits in the fuse filesystem.
   -->
   <interface name='org.freedesktop.portal.Documents'>
+    <property name="version" type="u" access="read"/>
 
     <!--
         GetMountPoint:
diff --git a/document-portal/xdp-main.c b/document-portal/xdp-main.c
index 2f1199f8..a5976d7d 100644
--- a/document-portal/xdp-main.c
+++ b/document-portal/xdp-main.c
@@ -873,6 +873,8 @@ on_bus_acquired (GDBusConnection *connection,
 
   dbus_api = xdp_dbus_documents_skeleton_new ();
 
+  xdp_dbus_documents_set_version (XDP_DBUS_DOCUMENTS (dbus_api), 1);
+
   g_signal_connect_swapped (dbus_api, "handle-get-mount-point", G_CALLBACK (handle_get_mount_point), NULL);
   g_signal_connect_swapped (dbus_api, "handle-add", G_CALLBACK (handle_method), portal_add);
   g_signal_connect_swapped (dbus_api, "handle-add-named", G_CALLBACK (handle_method), portal_add_named);
diff --git a/permission-store/xdg-permission-store.c b/permission-store/xdg-permission-store.c
index d6f14834..57601ea6 100644
--- a/permission-store/xdg-permission-store.c
+++ b/permission-store/xdg-permission-store.c
@@ -448,6 +448,8 @@ xdg_permission_store_start (GDBusConnection *connection)
 
   store = xdg_permission_store_skeleton_new ();
 
+  xdg_permission_store_set_version (XDG_PERMISSION_STORE (store), 1);
+
   g_signal_connect (store, "handle-list", G_CALLBACK (handle_list), NULL);
   g_signal_connect (store, "handle-lookup", G_CALLBACK (handle_lookup), NULL);
   g_signal_connect (store, "handle-set", G_CALLBACK (handle_set), NULL);
diff --git a/session-helper/flatpak-session-helper.c b/session-helper/flatpak-session-helper.c
index 3b57dbbf..17259fee 100644
--- a/session-helper/flatpak-session-helper.c
+++ b/session-helper/flatpak-session-helper.c
@@ -359,6 +359,9 @@ on_bus_acquired (GDBusConnection *connection,
   GError *error = NULL;
 
   helper = flatpak_session_helper_skeleton_new ();
+
+  flatpak_session_helper_set_version (FLATPAK_SESSION_HELPER (helper), 1);
+
   g_signal_connect (helper, "handle-request-monitor", G_CALLBACK (handle_request_monitor), NULL);
 
   if (!g_dbus_interface_skeleton_export (G_DBUS_INTERFACE_SKELETON (helper),
@@ -371,6 +374,7 @@ on_bus_acquired (GDBusConnection *connection,
     }
 
   devel = flatpak_development_skeleton_new ();
+  flatpak_development_set_version (FLATPAK_DEVELOPMENT (devel), 1);
   g_signal_connect (devel, "handle-host-command", G_CALLBACK (handle_host_command), NULL);
   g_signal_connect (devel, "handle-host-command-signal", G_CALLBACK (handle_host_command_signal), NULL);
 
diff --git a/system-helper/flatpak-system-helper.c b/system-helper/flatpak-system-helper.c
index 7e222911..e450284a 100644
--- a/system-helper/flatpak-system-helper.c
+++ b/system-helper/flatpak-system-helper.c
@@ -922,6 +922,8 @@ on_bus_acquired (GDBusConnection *connection,
 
   helper = flatpak_system_helper_skeleton_new ();
 
+  flatpak_system_helper_set_version (FLATPAK_SYSTEM_HELPER (helper), 1);
+
   g_object_set_data_full (G_OBJECT(helper), "track-alive", GINT_TO_POINTER(42), skeleton_died_cb);
 
   g_dbus_interface_skeleton_set_flags (G_DBUS_INTERFACE_SKELETON (helper),