From 3c99534f48d20820908019995c29961e4a34864a Mon Sep 17 00:00:00 2001 From: Andrea Claudi Date: Wed, 3 Sep 2025 09:44:56 +0200 Subject: [PATCH] tc: gred: fix debug print MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When build with -DDEBUG, tc build fails with: q_gred.c: In function ‘init_gred’: q_gred.c:53:17: error: passing argument 2 of ‘fprintf’ from incompatible pointer type [-Wincompatible-pointer-types] 53 | DPRINTF(stderr, "init_gred: invoked with %s\n", *argv); | ^~~~~~~ | | | FILE * This is due to the DPRINTF macro call. Indeed DPRINTF is defined as a two-args macro when -DDEBUG is used, while it uses 3 args in this call. Fix it simply dropping the useless first arg. Fixes: aba5acdfdb34 ("(Logical change 1.3)") Signed-off-by: Andrea Claudi Signed-off-by: Stephen Hemminger --- tc/q_gred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_gred.c b/tc/q_gred.c index 84fc9124..95573218 100644 --- a/tc/q_gred.c +++ b/tc/q_gred.c @@ -50,7 +50,7 @@ static int init_gred(const struct qdisc_util *qu, int argc, char **argv, opt.def_DP = MAX_DPs; while (argc > 0) { - DPRINTF(stderr, "init_gred: invoked with %s\n", *argv); + DPRINTF("init_gred: invoked with %s\n", *argv); if (strcmp(*argv, "vqs") == 0 || strcmp(*argv, "DPs") == 0) { NEXT_ARG();