ahill/iproute2
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/iproute2/iproute2.git synced 2026-01-26 14:13:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

ip: fix memory leak in 'ip maddr show'

Browse Source 
In `read_dev_mcast`, the list of ma_info is allocated, but not cleared
after use. Free the list in the end to make valgrind happy.

Detected by valgrind: "valgrind ./ip/ip maddr show"

Signed-off-by: Maxim Petrov <mmrmaximuzz@gmail.com>
This commit is contained in:
Maxim Petrov 2023-10-15 16:32:12 +02:00 committed by Stephen Hemminger
parent f1160a0f6b
commit 575322b09c
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ip/ipmaddr.c
View File

@ -79,6 +79,16 @@ static void maddr_ins(struct ma_info **lst, struct ma_info *m)
*lst = m;
}
static void maddr_clear(struct ma_info *lst)
{
struct ma_info *mp;
while ((mp = lst) != NULL) {
lst = mp->next;
free(mp);
}
}
static void read_dev_mcast(struct ma_info **result_p)
{
char buf[256];
@ -286,6 +296,7 @@ static int multiaddr_list(int argc, char **argv)
if (!filter.family || filter.family == AF_INET6)
read_igmp6(&list);
print_mlist(stdout, list);
maddr_clear(list);
return 0;
}