From 683815ed61eddffe90dc986ce8c8ed085a805158 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Tue, 13 Jan 2026 12:41:27 +0100 Subject: [PATCH] ip/iplink: fix off-by-one KIND length in modify() The expected size for IFLA_INFO_KIND in kernel is strlen(kind) + 1. See `size` in rtnl_link_get_size() in net/core/rtnetlink.c. Fixes: 1d93483985f0 ("iplink: use netlink for link configuration") Reported-by: Gris Ge Signed-off-by: Jan Vaclav Signed-off-by: Stephen Hemminger --- ip/iplink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink.c b/ip/iplink.c index 59e8caf4..fce6631d 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -1139,7 +1139,7 @@ static int iplink_modify(int cmd, unsigned int flags, int argc, char **argv) linkinfo = addattr_nest(&req.n, sizeof(req), IFLA_LINKINFO); addattr_l(&req.n, sizeof(req), IFLA_INFO_KIND, type, - strlen(type)); + strlen(type) + 1); lu = get_link_kind(type); if (ulinep && !strcmp(ulinep, "_slave"))