ahill/iproute2
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/network/iproute2/iproute2.git synced 2026-01-26 14:13:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

ss: Fix socket type check in packet_show_line()

Browse Source 
The field is accessed before being assigned a meaningful value,
effectively disabling the checks.

Fixes: 4a0053b606a34 ("ss: Unify packet stats output from netlink and proc")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This commit is contained in:
Phil Sutter 2023-08-22 14:19:16 +02:00 committed by Stephen Hemminger
parent 872148f54e
commit 92e9915c36
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
misc/ss.c
View File

@ -4535,9 +4535,9 @@ static int packet_show_line(char *buf, const struct filter *f, int fam)
&type, &prot, &iface, &state,
&rq, &uid, &ino);
if (stat.type == SOCK_RAW && !(f->dbs&(1<<PACKET_R_DB)))
if (type == SOCK_RAW && !(f->dbs & (1<<PACKET_R_DB)))
return 0;
if (stat.type == SOCK_DGRAM && !(f->dbs&(1<<PACKET_DG_DB)))
if (type == SOCK_DGRAM && !(f->dbs & (1<<PACKET_DG_DB)))
return 0;
stat.type = type;