ahill/nftables
1
0
Fork 0
mirror of https://git.netfilter.org/nftables synced 2026-01-26 10:34:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

mnl: Drop asterisk from end of NFTA_DEVICE_PREFIX strings

Browse Source 
The asterisk left in place becomes part of the prefix by accident and is thus
both included when matching interface names as well as dumped back to user
space.

Fixes: c31e887504a90 ("mnl: Support simple wildcards in netdev hooks")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Phil Sutter 2025-10-07 17:51:32 +02:00
parent b134dc2180
commit 11b9415fd6
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mnl.c
View File

@ -815,9 +815,16 @@ static bool is_wildcard_str(const char *str)
static void mnl_nft_attr_put_ifname(struct nlmsghdr *nlh, const char *ifname)
{
uint16_t attr = is_wildcard_str(ifname) ?
NFTA_DEVICE_PREFIX : NFTA_DEVICE_NAME;
uint16_t attr = NFTA_DEVICE_NAME;
char pfx[IFNAMSIZ];
if (is_wildcard_str(ifname)) {
snprintf(pfx, IFNAMSIZ, "%s", ifname);
pfx[strlen(pfx) - 1] = '\0';
attr = NFTA_DEVICE_PREFIX;
ifname = pfx;
}
mnl_attr_put_strz(nlh, attr, ifname);
}