ahill/nilfs-utils
1
0
Fork 0
mirror of https://github.com/nilfs-dev/nilfs-utils.git synced 2026-01-26 13:43:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

mount.nilfs2: check return value of mnt_fs_set_root()

Browse Source 
In nilfs_mnt_context_complete_root(), the return value of
mnt_fs_set_root() is ignored.

Since mnt_fs_set_root() involves memory allocation, it can fail and
return a negative error code (e.g., -ENOMEM).

Fix this by checking the return value and reporting an error if it fails.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
This commit is contained in:
Ryusuke Konishi 2026-01-13 23:42:10 +09:00
parent eba2555a37
commit d0e8cc2caf
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sbin/mount/mount_libmount.c
View File

@ -457,9 +457,15 @@ static int nilfs_mnt_context_complete_root(struct libmnt_context *cxt)
}
fs = nilfs_find_mount(cxt, mtab, mnt_context_get_target(cxt), NULL);
if (fs)
mnt_fs_set_root(mnt_context_get_fs(cxt), mnt_fs_get_root(fs));
if (fs) {
res = mnt_fs_set_root(mnt_context_get_fs(cxt),
mnt_fs_get_root(fs));
if (res < 0) {
error(_("%s: failed to copy root of the mount: %s"),
progname, strerror(-res));
goto failed;
}
}
res = 0;
failed:
return res;