nilfs-utils/sbin/Makefile.am
Ryusuke Konishi eb327bf71c mkfs.nilfs2: introduce bitops.h for external bit operations
The functions 'ext2fs_set_bit', 'ext2fs_clear_bit', and 'ext2fs_test_bit'
are defined in bitops.c but were previously declared locally in mkfs.h.
This prevented bitops.c from seeing its own prototypes, triggering
Sparse warnings about undeclared symbols.

Extract these declarations into a new header file "bitops.h" and include
it in both bitops.c and mkfs.h.  This ensures that the definitions match
the declarations and resolves the scope issues.

This resolves the following Sparse warnings:

bitops.c:19:5: warning: symbol 'ext2fs_set_bit' was not declared. Should
 it be static?
bitops.c:31:5: warning: symbol 'ext2fs_clear_bit' was not declared. Should
 it be static?
bitops.c:43:5: warning: symbol 'ext2fs_test_bit' was not declared. Should
 it be static?

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
2026-01-11 01:18:09 +09:00

73 lines
2.3 KiB
Makefile

## Makefile.am
SUBDIRS = mount
AM_CFLAGS = -Wall
AM_CPPFLAGS = -I$(top_srcdir)/include
LDADD = $(top_builddir)/lib/libnilfs.la
core_sbin_PROGRAMS = mkfs.nilfs2 nilfs_cleanerd
sbin_PROGRAMS = nilfs-clean nilfs-resize nilfs-tune
mkfs_nilfs2_SOURCES = mkfs.c bitops.c mkfs.h bitops.h
mkfs_nilfs2_CPPFLAGS = $(AM_CPPFLAGS) -DBADBLOCKSDIR=\"$(badblocksdir)\"
mkfs_nilfs2_CFLAGS = $(AM_CFLAGS) $(BLKID_CFLAGS) $(UUID_CFLAGS)
mkfs_nilfs2_LDADD = $(BLKID_LIBS) $(UUID_LIBS) \
$(top_builddir)/lib/libcrc32.la \
$(top_builddir)/lib/libmountchk.la \
$(top_builddir)/lib/libnilfsfeature.la
nilfs_cleanerd_SOURCES = cleanerd.c cldconfig.c cldconfig.h
nilfs_cleanerd_CPPFLAGS = $(AM_CPPFLAGS) -DSYSCONFDIR=\"$(sysconfdir)\"
# Use internal convenience libraries to make nilfs_cleanerd self-contained.
nilfs_cleanerd_CFLAGS = $(AM_CFLAGS) $(UUID_CFLAGS)
nilfs_cleanerd_LDADD = $(LIB_POSIX_MQ) $(UUID_LIBS) \
$(top_builddir)/lib/libnilfsgc_static.la
nilfs_clean_SOURCES = nilfs-clean.c
nilfs_clean_LDADD = $(LDADD) $(top_builddir)/lib/libcleaner.la \
$(top_builddir)/lib/libparser.la
nilfs_resize_SOURCES = nilfs-resize.c
nilfs_resize_LDADD = $(LDADD) $(top_builddir)/lib/libmountchk.la \
$(top_builddir)/lib/libnilfsgc.la
nilfs_tune_SOURCES = nilfs-tune.c
nilfs_tune_LDADD = $(LDADD) $(top_builddir)/lib/libmountchk.la \
$(top_builddir)/lib/libnilfsfeature.la
EXTRA_DIST = .gitignore
# Define dependencies so that the target binary is not blocked by a directory
# with the same name
fix-conflicting-dirs:
@for p in $(sbin_PROGRAMS); do \
if [ -d "$$p" ]; then \
echo "Removing directory '$$p' to allow binary creation"; \
rm -rf "$$p"; \
fi; \
done
$(sbin_PROGRAMS): fix-conflicting-dirs
if CREATE_COMPAT_SBIN_LINK
install-exec-hook:
@if [ -d "$(DESTDIR)$(exec_prefix)/sbin" ]; then \
for p in $(sbin_PROGRAMS) $(core_sbin_PROGRAMS); do \
echo " LN $(DESTDIR)$(exec_prefix)/sbin/$$p"; \
ln -sf ../bin/$$p $(DESTDIR)$(exec_prefix)/sbin/$$p; \
done; \
fi
uninstall-hook:
@if [ -d "$(DESTDIR)$(exec_prefix)/sbin" ]; then \
for p in $(sbin_PROGRAMS) $(core_sbin_PROGRAMS); do \
if [ -L "$(DESTDIR)$(exec_prefix)/sbin/$$p" ]; then \
echo " RM $(DESTDIR)$(exec_prefix)/sbin/$$p"; \
rm -f "$(DESTDIR)$(exec_prefix)/sbin/$$p"; \
fi; \
done; \
fi
endif # CREATE_COMPAT_SBIN_LINK