ahill/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-01-26 06:07:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

bluez5: Use named constants for Bluetooth codec IDs

Browse Source 
Replace magic numbers (0x02, 0x05) with named constants BT_CODEC_CVSD
and BT_CODEC_MSBC for better code readability. Also remove redundant
zero initialization of num_caps field since the buffer is already
memset to zero.
This commit is contained in:
Mengshi Wu 2026-01-19 15:17:11 +08:00 committed by Wim Taymans
parent 78f16bc04b
commit 254620676f
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spa/plugins/bluez5/backend-native.c
View File

@ -63,6 +63,9 @@ SPA_LOG_TOPIC_DEFINE_STATIC(log_topic, "spa.bluez5.native");
#define RFCOMM_MESSAGE_MAX_LENGTH 256 #define RFCOMM_MESSAGE_MAX_LENGTH 256
#define BT_CODEC_CVSD 0x02
#define BT_CODEC_MSBC 0x05
enum { enum {
HFP_AG_INITIAL_CODEC_SETUP_NONE = 0, HFP_AG_INITIAL_CODEC_SETUP_NONE = 0,
HFP_AG_INITIAL_CODEC_SETUP_SEND, HFP_AG_INITIAL_CODEC_SETUP_SEND,
@ -312,12 +315,11 @@ static void sco_offload_btcodec(struct impl *backend, int sock, bool msbc)
memset(buffer, 0, sizeof(buffer)); memset(buffer, 0, sizeof(buffer));
codecs = (void *)buffer; codecs = (void *)buffer;
if (msbc) if (msbc)
codecs->codecs[0].id = 0x05; codecs->codecs[0].id = BT_CODEC_MSBC;
else else
codecs->codecs[0].id = 0x02; codecs->codecs[0].id = BT_CODEC_CVSD;
codecs->num_codecs = 1; codecs->num_codecs = 1;
codecs->codecs[0].data_path_id = backend->hfphsp_sco_datapath; codecs->codecs[0].data_path_id = backend->hfphsp_sco_datapath;
codecs->codecs[0].num_caps = 0x00;
err = setsockopt(sock, SOL_BLUETOOTH, BT_CODEC, codecs, sizeof(buffer)); err = setsockopt(sock, SOL_BLUETOOTH, BT_CODEC, codecs, sizeof(buffer));
if (err < 0) if (err < 0)