From 7e605222df006458a2edfbbe3875db858eff115e Mon Sep 17 00:00:00 2001 From: Serge Hallyn Date: Wed, 26 Mar 2025 08:23:52 -0500 Subject: [PATCH] Quick fix: define E_PAM_ERR in lib/pam_pass.c The exit code situation is a hot mess. Do a git grep "define.*E_SUCCESS" Each src/*.c is defining its own set of error codes, and they are frequently conflicting, e.g. more than one use 10. We should probably have a common set defined in lib/exitcodes.h. I'm thinking for a first cut, we just move all the definitions from src/*.c to lib/exitcodes.h, and let the conflicts stand. If we later want to change some defines to make them unambiguous across the project, we can do that separately. Signed-off-by: Serge Hallyn --- lib/pam_pass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/pam_pass.c b/lib/pam_pass.c index 0e3ec4c0..33536568 100644 --- a/lib/pam_pass.c +++ b/lib/pam_pass.c @@ -10,6 +10,9 @@ #ifdef USE_PAM +/* Copied from src/passwd.c */ +#define E_PAM_ERR 10 /* PAM returned an error */ + #ident "$Id$"