ahill/shadow
1
0
Fork 0
mirror of https://github.com/shadow-maint/shadow.git synced 2026-01-26 14:03:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/subordinateio.c: append_range(): Use reallocf(3)-like calling conventions

Browse Source 
By returning the new pointer, we can simplify the implementation,
and we avoid a return-by-parameter.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
This commit is contained in:
Alejandro Colomar 2025-08-24 09:48:23 +02:00 committed by Serge Hallyn
parent 64bdbe08f6
commit ceaca8460f
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/subordinateio.c
View File

@ -275,16 +275,17 @@ static const struct subordinate_range *find_range(struct commonio_db *db,
static bool have_range(struct commonio_db *db,
const char *owner, unsigned long start, unsigned long count);
static bool append_range(struct subid_range **ranges, const struct subordinate_range *new, int n)
static struct subid_range *
append_range(struct subid_range *ranges, const struct subordinate_range *new, int n)
{
*ranges = REALLOCF(*ranges, n + 1, struct subid_range);
if (!*ranges)
return false;
ranges = REALLOCF(ranges, n + 1, struct subid_range);
if (ranges == NULL)
return NULL;
(*ranges)[n].start = new->start;
(*ranges)[n].count = new->count;
ranges[n].start = new->start;
ranges[n].count = new->count;
return true;
return ranges;
}
void free_subordinate_ranges(struct subordinate_range **ranges, int count)
@ -916,7 +917,8 @@ int list_owner_ranges(const char *owner, enum subid_type id_type, struct subid_r
if ( streq(range->owner, owner)
|| (have_owner_id && streq(range->owner, id)))
{
if (!append_range(&ranges, range, count++)) {
ranges = append_range(ranges, range, count++);
if (ranges == NULL) {
count = -1;
goto out;
}