ahill/shadow
1
0
Fork 0
mirror of https://github.com/shadow-maint/shadow.git synced 2026-01-26 22:12:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
shadow/lib
History
Alejandro Colomar 69b9883fee
lib/port.c: getportent(): Make sure the aren't too many fields in the CSV 
Otherwise, the line is invalidly formatted, and we ignore it.

Detailed explanation:

There are two conditions on which we break out of the loops that precede
these added checks:

-  j is too big (we've exhausted the space in the static arrays)

	$ grep -r -e PORT_TTY -e PORT_IDS lib/port.*
	lib/port.c:	static char *ttys[PORT_TTY + 1];	/* some pointers to tty names     */
	lib/port.c:	static char *users[PORT_IDS + 1];	/* some pointers to user ids     */
	lib/port.c:	for (cp = buf, j = 0; j < PORT_TTY; j++) {
	lib/port.c:			if ((',' == *cp) && (j < PORT_IDS)) {
	lib/port.h: * PORT_IDS - Allowable number of IDs per entry.
	lib/port.h: * PORT_TTY - Allowable number of TTYs per entry.
	lib/port.h:#define	PORT_IDS	64
	lib/port.h:#define	PORT_TTY	64

-  strpbrk(3) found a ':', which signals the end of the comma-sepatated
   list, and the start of the next colon-separated field.

If the first character in the remainder of the string is not a ':', it
means we've exhausted the array size, but the CSV list was longer, so
we'd be truncating it.  Consider the entire line invalid, and skip it.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
Cherry-picked-from: a19805445672 ("lib/port.c: getportent(): Make sure the aren't too many fields in the CSV")
Link: <https://github.com/shadow-maint/shadow/pull/1037>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
2024-07-15 00:56:59 +02:00
..
atoi
lib/atoi/strtou_noneg.[ch], tests/: strtoul_noneg(): Remove unused function
2024-05-27 16:32:09 +02:00
string
lib/string/strftime.[ch]: STRFTIME(): Add macro
2024-03-24 00:16:00 +01:00
time
lib/, src/: Call gmtime_r(3) instead of gmtime(3)
2024-03-14 16:30:46 -05:00
.indent.pro
…
addgrps.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
adds.c
lib/, tests/: addsl(): Add addsl(), a variadic macro
2024-01-16 16:58:18 +01:00
adds.h
lib/, tests/: addsl(): Add addsl(), a variadic macro
2024-01-16 16:58:18 +01:00
age.c
lib/: Saturate addition to avoid overflow
2024-02-13 16:02:49 -06:00
agetpass.c
src/passwd.c: inconsistent password length limit
2024-02-16 15:46:08 -06:00
agetpass.h
lib/agetpass.[ch]: add function ro read from pipe
2024-01-31 22:16:02 -06:00
alloc.c
lib, libmisc: Move source files to lib (where their headers were)
2023-08-30 17:22:38 +02:00
alloc.h
lib/alloc.h: Reimplement [X]REALLOC[F]() macros with _Generic(3)
2024-05-15 12:08:00 +02:00
attr.h
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
audit_help.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
basename.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
bit.c
lib, libmisc: Move source files to lib (where their headers were)
2023-08-30 17:22:38 +02:00
bit.h
lib: bit_ceil_wrapul(): stop recursion
2023-02-24 12:44:14 -06:00
btrfs.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
cast.h
lib/cast.h: const_cast(): Reimplement with _Generic(3)
2024-06-04 09:10:23 +02:00
chkname.c
lib/chkname.[ch]: login_name_max_size(): Add function
2024-05-21 13:26:41 +02:00
chkname.h
lib/chkname.[ch]: login_name_max_size(): Add function
2024-05-21 13:26:41 +02:00
chowndir.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
chowntty.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
cleanup_group.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
cleanup_user.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
cleanup.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
commonio.c
lib/: get_pid(): Use the usual -1 as an error code
2024-01-05 16:54:55 -06:00
commonio.h
lib/: Use 'restrict' alongside [[gnu::access()]]
2024-01-15 13:14:28 -06:00
console.c
lib/string/: Move string-related files to string/ subdir
2023-12-03 12:22:11 -06:00
copydir.c
lib/copydir:copy_entry(): use temporary stat buffer
2024-03-21 02:44:12 +01:00
csrand.c
lib/csrand.c: Fix the lower part of the domain of csrand_uniform()
2024-06-21 10:57:17 +02:00
defines.h
src/passwd.c: inconsistent password length limit
2024-02-16 15:46:08 -06:00
encrypt.c
Merge pull request #451 from hallyn/2021-12-05/license
2022-01-02 18:38:42 -06:00
env.c
lib/env.c: treat out of memory condition as error
2024-04-04 20:12:03 +02:00
exitcodes.h
Update licensing info
2021-12-23 19:36:50 -06:00
faillog.h
Update licensing info
2021-12-23 19:36:50 -06:00
failure.c
lib/, src/: Use STRFTIME() instead of its pattern
2024-03-24 00:16:00 +01:00
failure.h
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
fd.c
Adding checks for fd omission
2024-03-10 19:56:40 -05:00
fields.c
Overhaul valid_field()
2023-03-31 09:53:40 -05:00
find_new_gid.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
find_new_sub_gids.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
find_new_sub_uids.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
find_new_uid.c
Use CALLOC() instead of its pattern
2023-09-01 09:39:23 +02:00
fputsx.c
lib/: Use 'restrict' alongside [[gnu::access()]]
2024-01-15 13:14:28 -06:00
freezero.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
freezero.h
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
get_gid.c
lib/, src/: Rename some local variables
2024-05-04 17:22:57 -05:00
get_pid.c
lib/, src/: Rename some local variables
2024-05-04 17:22:57 -05:00
get_uid.c
lib/, src/: Rename some local variables
2024-05-04 17:22:57 -05:00
getdate.h
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
getdate.y
lib/, src/: Use int main(void) where appropriate
2024-03-14 16:16:15 -05:00
getdef.c
lib/, src/: str2*(): Rename functions and reorder parameters
2024-03-29 14:29:13 -05:00
getdef.h
Improve the login.defs unknown item error message
2023-10-20 18:46:23 -05:00
getgr_nam_gid.c
lib/, src/: Rename some local variables
2024-05-04 17:22:57 -05:00
getrange.c
lib/getrange.c: getrange(): Report an error when min>max
2024-05-17 15:40:03 +02:00
gettime.c
lib/gettime.c: gettime(): Call a2i() instead of strtoull_noneg()
2024-05-27 16:32:09 +02:00
groupio.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
groupio.h
Update licensing info
2021-12-23 19:36:50 -06:00
groupmem.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
gshadow_.h
Update licensing info
2021-12-23 19:36:50 -06:00
gshadow.c
lib/: Call strsep(3) instead of open-coding it
2024-03-14 17:11:36 -05:00
hushed.c
lib/, src/: Use SNPRINTF() instead of its pattern
2023-12-15 16:41:47 +01:00
idmapping.c
lib/, src/: str2*(): Rename functions and reorder parameters
2024-03-29 14:29:13 -05:00
idmapping.h
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
isexpired.c
lib/: Saturate addition to avoid overflow
2024-02-13 16:02:49 -06:00
limits.c
lib/, src/: Rename some local variables
2024-05-04 17:22:57 -05:00
list.c
lib/list.c: is_on_list(): Call strsep(3) instead of open-coding it
2024-03-14 17:11:36 -05:00
lockpw.c
Don't redefine errno(3)
2022-12-22 11:43:29 +01:00
log.c
lib/, src/, configure.ac: Use utmpx instead of utmp
2024-02-20 18:53:53 +01:00
logind.c
lib/, src/: Make the use of MAYBE_UNUSED macro consistent
2024-01-30 16:19:56 +01:00
loginprompt.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
mail.c
lib/string/: Move string-related files to string/ subdir
2023-12-03 12:22:11 -06:00
Makefile.am
lib/atoi/: Add a2[su]l() and reimplement get[u]long() in terms of them
2024-03-29 14:29:13 -05:00
memzero.c
memzero.[ch]: Define memzero() and strzero() as inline functions
2023-09-01 09:39:23 +02:00
memzero.h
Use bzero(3) instead of its pattern
2023-09-01 09:39:23 +02:00
motd.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
must_be.h
lib/must_be.h: is_same_type(): Add macro
2024-01-26 09:40:10 +01:00
myname.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
nscd.c
Don't redefine errno(3)
2022-12-22 11:43:29 +01:00
nscd.h
…
nss.c
lib/, src/: Use SNPRINTF() instead of its pattern
2023-12-15 16:41:47 +01:00
obscure.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
pam_defs.h
Declare constant data structure const
2023-01-25 12:31:17 +01:00
pam_pass_non_interactive.c
lib/pam_pass_non_interactive.c: use strzero/free
2024-03-14 17:20:30 -05:00
pam_pass.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
port.c
lib/port.c: getportent(): Make sure the aren't too many fields in the CSV
2024-07-15 00:56:59 +02:00
port.h
Update licensing info
2021-12-23 19:36:50 -06:00
prefix_flag.c
lib/, src/: Rename some local variables
2024-05-04 17:22:57 -05:00
prototypes.h
lib/, src/, po/: get[u]long(): Move functions to lib/atoi/str2i.h
2024-03-29 14:29:13 -05:00
pwauth.c
lib/, src/: Use SNPRINTF() instead of its pattern
2023-12-15 16:41:47 +01:00
pwauth.h
Add header guards
2022-05-24 07:49:11 -05:00
pwd2spwd.c
lib/, src/: Remove SCALE definition
2024-01-05 15:41:12 -06:00
pwd_init.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
pwdcheck.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
pwio.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
pwio.h
Update licensing info
2021-12-23 19:36:50 -06:00
pwmem.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
readpassphrase.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
readpassphrase.h
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
remove_tree.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
rlogin.c
lib/, src/: str2*(): Rename functions and reorder parameters
2024-03-29 14:29:13 -05:00
root_flag.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
run_part.c
lib/: Add missing #include <config.h>
2023-10-20 21:05:33 +02:00
run_part.h
Add header guards
2022-05-24 07:49:11 -05:00
salt.c
Use bzero(3) instead of its pattern
2023-09-01 09:39:23 +02:00
selinux.c
selinux: use type safe function pointer assignment
2023-03-20 08:47:52 +01:00
semanage.c
lib/, src/: Rename 'unused' macro as 'MAYBE_UNUSED'
2024-01-30 16:19:56 +01:00
setugid.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
setupenv.c
lib/string/: Move string-related files to string/ subdir
2023-12-03 12:22:11 -06:00
sgetgrent.c
lib/: Call strsep(3) instead of open-coding it
2024-03-14 17:11:36 -05:00
sgetpwent.c
lib/: Call strsep(3) instead of open-coding it
2024-03-14 17:11:36 -05:00
sgetspent.c
lib/, src/: str2*(): Rename functions and reorder parameters
2024-03-29 14:29:13 -05:00
sgroupio.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
sgroupio.h
Update licensing info
2021-12-23 19:36:50 -06:00
shadow.c
lib/, src/: str2*(): Rename functions and reorder parameters
2024-03-29 14:29:13 -05:00
shadowio.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
shadowio.h
Update licensing info
2021-12-23 19:36:50 -06:00
shadowlog_internal.h
Fix typos
2023-01-26 22:44:39 -06:00
shadowlog.c
lib: provide default values for shadow_progname/shadow_logfd
2021-12-27 16:28:23 +00:00
shadowlog.h
Drop obsolete prototype for log_dolog()
2022-08-06 11:27:56 -05:00
shadowmem.c
lib/: Remove incorrect /*@out@*/ comment from functions that read the pointee
2024-01-15 13:14:28 -06:00
shell.c
lib/, src/: Use SNPRINTF() instead of its pattern
2023-12-15 16:41:47 +01:00
sizeof.h
lib/sizeof.h: memberof(): Add macro
2024-02-20 18:53:53 +01:00
spawn.c
lib/: Use 'restrict' alongside [[gnu::access()]]
2024-01-15 13:14:28 -06:00
sssd.c
Simplify allocation APIs
2023-06-08 09:05:39 -05:00
sssd.h
Flush sssd caches in addition to nscd caches
2018-09-13 14:20:02 +02:00
strtoday.c
lib/, src/: str2*(): Rename functions and reorder parameters
2024-03-29 14:29:13 -05:00
sub.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
subordinateio.c
have_range: open the subid db if needed
2024-06-28 23:39:37 +02:00
subordinateio.h
fix newusers when nss provides subids
2021-05-23 08:16:16 -05:00
sulog.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
tcbfuncs.c
lib/tcbfuncs: operate on file descriptor rather than path
2023-08-21 11:29:17 +02:00
tcbfuncs.h
…
ttytype.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
tz.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
ulimit.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
user_busy.c
lib/, src/, configure.ac: Use utmpx instead of utmp
2024-02-20 18:53:53 +01:00
utmp.c
lib/utmp.c: Use the appropriate autotools macros for struct utmpx
2024-02-21 15:43:25 +01:00
valid.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
write_full.c
libmisc/write_full.c: Improve write_full()
2023-08-18 20:35:15 -05:00
xgetgrgid.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
xgetgrnam.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
xgetpwnam.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
xgetpwuid.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
xgetspnam.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
xgetXXbyYY.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
xprefix_getpwnam.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00
yesno.c
lib: Merge libmisc into libshadow
2023-08-31 08:55:26 +02:00