From bf24ecb95b4fb13ba051874cb0debcd2e65c53cf Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Tue, 25 Nov 2025 00:44:30 +0200 Subject: [PATCH] glamor: silence false positive in glamor_validate_gc() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We know that if gc->tileIsPixel is false, then gc->tile.pixmap must be a valid pixmap, but gcc's static analyzer doesn't and needs to be told. Silences false positive reported in https://gitlab.freedesktop.org/xorg/xserver/-/issues/1817: xwayland-24.1.6/redhat-linux-build/../glamor/glamor_core.c:205:19: warning[-Wanalyzer-null-dereference]: dereference of NULL ‘0’ Signed-off-by: default avatarAlan Coopersmith Part-of: --- glamor/glamor_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/glamor/glamor_core.c b/glamor/glamor_core.c index 8ad49ca3c..b04909cb9 100644 --- a/glamor/glamor_core.c +++ b/glamor/glamor_core.c @@ -207,6 +207,8 @@ glamor_validate_gc(GCPtr gc, unsigned long changes, DrawablePtr drawable) */ if (changes & GCTile) { if (!gc->tileIsPixel) { + assert(gc->tile.pixmap != NullPixmap); + glamor_pixmap_private *pixmap_priv = glamor_get_pixmap_private(gc->tile.pixmap); if ((!GLAMOR_PIXMAP_PRIV_HAS_FBO(pixmap_priv))