mirror/coreutils
1
0
Fork 0
mirror of https://https.git.savannah.gnu.org/git/coreutils.git synced 2026-01-27 01:44:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

maint: ln: eliminate a clang -Wformat-extra-args warning

Browse Source 
* src/ln.c (do_link): Don't pass unused arguments to error().
Don't use "%.0s" to consume a string argument without printing it.
This commit is contained in:
Bruno Haible 2025-09-18 23:19:01 +02:00 committed by Pádraig Brady
parent 8db63075a5
commit d5cc0c3b8a
1 changed files with 25 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/ln.c
View File

@ -369,18 +369,31 @@ do_link (char const *source, int destdir_fd, char const *dest_base,
}
else
{
error (0, link_errno,
(symbolic_link
? (link_errno != ENAMETOOLONG && *source
? _("failed to create symbolic link %s")
: _("failed to create symbolic link %s -> %s"))
: (link_errno == EMLINK
? _("failed to create hard link to %.0s%s")
: (link_errno == EDQUOT || link_errno == EEXIST
|| link_errno == ENOSPC || link_errno == EROFS)
? _("failed to create hard link %s")
: _("failed to create hard link %s => %s"))),
quoteaf_n (0, dest), quoteaf_n (1, source));
char *dest_quoted = quoteaf_n (0, dest);
char *source_quoted = quoteaf_n (1, source);
if (symbolic_link)
{
if (link_errno != ENAMETOOLONG && *source)
error (0, link_errno, _("failed to create symbolic link %s"),
dest_quoted);
else
error (0, link_errno, _("failed to create symbolic link %s -> %s"),
dest_quoted, source_quoted);
}
else
{
if (link_errno == EMLINK)
error (0, link_errno, _("failed to create hard link to %s"),
source_quoted);
else if (link_errno == EDQUOT || link_errno == EEXIST
|| link_errno == ENOSPC || link_errno == EROFS)
error (0, link_errno, _("failed to create hard link %s"),
dest_quoted);
else
error (0, link_errno, _("failed to create hard link %s => %s"),
dest_quoted, source_quoted);
}
if (backup_base)
{