Eric Blake 1c59bb3cef nice, nohup, su: detect write failure to stderr
These programs can print non-fatal diagnostics to stderr prior to
exec'ing a subsidiary program.  However, if we thought the situation
warranted a diagnostic, we insist that the diagnostic be printed
without error, rather than blindly exec, as it may be a security risk.

For an example, try 'nice -n -1 nice 2>/dev/full'.  Failure to raise
priority (by lowering niceness) is not fatal, but failure to inform
the user about failure to change priority is dangerous.

* src/nice.c (main): Declare failure if writing advisory message
to stderr fails.
* src/nohup.c (main): Likewise.
* src/su.c (main): Likewise.
* tests/misc/nice: Test this.
* tests/misc/nohup: Likewise.
* NEWS: Document this.
2009-10-28 21:12:41 -06:00

127 lines
3.3 KiB
Bash
Executable File

#!/bin/sh
# test nohup
# Copyright (C) 2003, 2006-2009 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
if test "$VERBOSE" = yes; then
set -x
nohup --version
fi
. $srcdir/test-lib.sh
fail=0
nohup sh -c 'echo stdout; echo stderr 1>&2' 2>err || fail=1
# Be careful. The results of the above nohup command
# change depending on whether stdin and stdout are redirected.
if test -t 1; then
test "`cat nohup.out`" = stdout || fail=1
if test -t 0; then
echo 'nohup: ignoring input and appending output to `nohup.out'\'
else
echo 'nohup: appending output to `nohup.out'\'
fi >exp || fail=1
else
# Here it should not even exist.
test -f nohup.out && fail=1
if test -t 0; then
echo 'nohup: ignoring input' >exp
else
rm -f exp
fi || fail=1
fi
echo 'stderr' >> exp || fail=1
compare exp err || fail=1
rm -f nohup.out err exp
# ----------------------
# Be careful. The results of the following nohup command
# change depending on whether stderr is redirected.
nohup sh -c 'echo stdout; echo stderr 1>&2' >out || fail=1
if test -t 2; then
test "`cat out|tr '\n' -`" = stdout-stderr- || fail=1
else
test "`cat out|tr '\n' -`" = stdout- || fail=1
fi
# It must *not* exist.
test -f nohup.out && fail=1
rm -f nohup.out err
# ----------------------
# Bug present through coreutils 8.0: failure to print advisory message
# to stderr must be fatal. Requires stdout to be terminal.
if test -w /dev/full && test -c /dev/full; then
(
exec >/dev/tty
test -t 1 || exit 0
nohup echo hi 2> /dev/full
test $? = 125 || fail=1
test -f nohup.out || fail=1
test -s nohup.out && fail=1
rm -f nohup.out
exit $fail
) || fail=1
fi
nohup no-such-command 2> err
errno=$?
if test -t 1; then
test $errno = 127 || fail=1
# It must exist.
test -f nohup.out || fail=1
# It must be empty.
test -s nohup.out && fail=1
fi
cat <<\EOF > exp || fail=1
nohup: appending output to `nohup.out'
nohup: cannot run command `no-such-command': No such file or directory
EOF
# Disable these comparisons. Too much variation in 2nd line.
# compare exp err || fail=1
rm -f nohup.out err exp
# ----------------------
touch k; chmod 0 k
nohup ./k 2> err
errno=$?
test $errno = 126 || fail=1
if test -t 1; then
# It must exist.
test -f nohup.out || fail=1
# It must be empty.
test -s nohup.out && fail=1
fi
cat <<\EOF > exp || fail=1
nohup: appending output to `nohup.out'
nohup: cannot run command `./k': Permission denied
EOF
# Disable these comparisons. Too much variation in 2nd line.
# compare exp err || fail=1
# Make sure it fails with exit status of 125 when given too few arguments,
# except that POSIX requires 127 in this case.
nohup >/dev/null 2>&1
test $? = 125 || fail=1
POSIXLY_CORRECT=1 nohup >/dev/null 2>&1
test $? = 127 || fail=1
Exit $fail