mirror/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2026-01-26 21:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

gh-142438: Added missing GIL release in _PySSL_keylog_callback when keylog_bio is unset (gh-142439)

Browse Source
This commit is contained in:
AZero13 2025-12-11 09:30:39 -05:00 committed by GitHub
parent 79aa43a979
commit 44d3dc6491
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2025-12-08-18-12-44.gh-issue-142438.UF_0nd.rst Normal file
View File

@ -0,0 +1 @@
Fixed a possible leaked GIL in _PySSL_keylog_callback.

4
Modules/_ssl/debughelpers.c
View File

@ -131,7 +131,7 @@ _PySSL_keylog_callback(const SSL *ssl, const char *line)
PyThread_type_lock lock = get_state_sock(ssl_obj)->keylog_lock;
assert(lock != NULL);
if (ssl_obj->ctx->keylog_bio == NULL) {
return;
goto done;
}
/*
* The lock is neither released on exit nor on fork(). The lock is
@ -155,6 +155,8 @@ _PySSL_keylog_callback(const SSL *ssl, const char *line)
ssl_obj->ctx->keylog_filename);
ssl_obj->exc = PyErr_GetRaisedException();
}
done:
PyGILState_Release(threadstate);
}