mirror/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-01-26 15:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

ftp: fix port number range loop for PORT commands

Browse Source 
If the last port to test is 65535, the loop would previously wrongly
wrap the counter and start over at 0, which was not intended.

Reported in Joshua's sarif data

Closes #18636
This commit is contained in:
Daniel Stenberg 2025-09-20 14:45:47 +02:00
parent 2a5da01e42
commit 277ebca610
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/ftp.c
View File

@ -1121,14 +1121,16 @@ static CURLcode ftp_state_use_port(struct Curl_easy *data,
else
break;
/* check if port is the maximum value here, because it might be 0xffff and
then the increment below will wrap the 16 bit counter */
if(port == port_max) {
/* maybe all ports were in use already */
failf(data, "bind() failed, ran out of ports");
goto out;
}
port++;
}
/* maybe all ports were in use already */
if(port > port_max) {
failf(data, "bind() failed, we ran out of ports");
goto out;
}
/* get the name again after the bind() so that we can extract the
port number it uses now */