mirror of
https://github.com/curl/curl.git
synced 2026-01-26 15:03:21 +00:00
Drop separate `TrackMemory` (aka `CURLDEBUG`) debug feature. After recent changes (thread-safety, 193cb00ce9b47e75d42157c650cc3de3fd96d35d, and updates leading up to it), `TrackMemory` is unlikely to cause build or runtime issues. To simplify builds and debug options, enable `TrackMemory` unconditionally for debug-enabled (aka `DEBUGBUILD`) builds. Before this patch, this was already the default, with an option to disable it, or enable it in non-debug-enabled builds. Note, in practice these two debug options already went hand in hand. It was not possible to toggle them separately for a long time due to bugs, before 59dc9f7e69c399102e9ebe3670360ef52706ff23 (2024-05-28) fixed it. This patch also removes/deprecates separate knobs and feature flags for `TrackMemory`: - autotools: `--enable-curldebug`/`--disable-curldebug` - cmake: `-DENABLE_CURLDEBUG=ON`/`OFF` - C macro: `CURLDEBUG` - libcurl: `CURL_VERSION_CURLDEBUG` symbol deprecated in favor of `CURL_VERSION_DEBUG`. They always return the same value after this patch. Also: - drop `TrackMemory` from `curl -V` output. - rename internal `CURLDEBUG` macro to `CURL_MEMDEBUG` internally. To avoid confusion with `DEBUGBUILD`, but to keep guarding `TrackMemory`-related internals for readability. - runtests: bind `TrackMemory` to debug feature. Keep it a separate test feature requirement, for clarity. - CI: drop test builds for combinations of the two options. - GHA/linux: no longer disable TrackMemory in the TSAN job. Ref: https://github.com/curl/curl/pull/20328#issuecomment-3754528407 Closes #20331
509 lines
13 KiB
C
509 lines
13 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "../curl_setup.h"
|
|
|
|
#include "fopen.h"
|
|
|
|
int curlx_fseek(void *stream, curl_off_t offset, int whence)
|
|
{
|
|
#ifdef _WIN32
|
|
return _fseeki64(stream, (__int64)offset, whence);
|
|
#elif defined(HAVE_FSEEKO) && defined(HAVE_DECL_FSEEKO)
|
|
return fseeko(stream, (off_t)offset, whence);
|
|
#else
|
|
if(offset > LONG_MAX)
|
|
return -1;
|
|
return fseek(stream, (long)offset, whence);
|
|
#endif
|
|
}
|
|
|
|
#ifdef _WIN32
|
|
|
|
#include <share.h> /* for _SH_DENYNO */
|
|
|
|
#include "multibyte.h"
|
|
#include "timeval.h"
|
|
|
|
#ifdef CURL_MEMDEBUG
|
|
/*
|
|
* Use system allocators to avoid infinite recursion when called by curl's
|
|
* memory tracker memdebug functions.
|
|
*/
|
|
#define CURLX_MALLOC(x) malloc(x)
|
|
#define CURLX_FREE(x) free(x)
|
|
#else
|
|
#define CURLX_MALLOC(x) curlx_malloc(x)
|
|
#define CURLX_FREE(x) curlx_free(x)
|
|
#endif
|
|
|
|
#ifdef _UNICODE
|
|
static wchar_t *fn_convert_UTF8_to_wchar(const char *str_utf8)
|
|
{
|
|
wchar_t *str_w = NULL;
|
|
|
|
if(str_utf8) {
|
|
int str_w_len = MultiByteToWideChar(CP_UTF8, MB_ERR_INVALID_CHARS,
|
|
str_utf8, -1, NULL, 0);
|
|
if(str_w_len > 0) {
|
|
str_w = CURLX_MALLOC(str_w_len * sizeof(wchar_t));
|
|
if(str_w) {
|
|
if(MultiByteToWideChar(CP_UTF8, 0,
|
|
str_utf8, -1, str_w, str_w_len) == 0) {
|
|
CURLX_FREE(str_w);
|
|
return NULL;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return str_w;
|
|
}
|
|
#endif
|
|
|
|
/* declare GetFullPathNameW for mingw-w64 UWP builds targeting old windows */
|
|
#if defined(CURL_WINDOWS_UWP) && defined(__MINGW32__) && \
|
|
(_WIN32_WINNT < _WIN32_WINNT_WIN10)
|
|
WINBASEAPI DWORD WINAPI GetFullPathNameW(LPCWSTR, DWORD, LPWSTR, LPWSTR *);
|
|
#endif
|
|
|
|
/* Fix excessive paths (paths that exceed MAX_PATH length of 260).
|
|
*
|
|
* This is a helper function to fix paths that would exceed the MAX_PATH
|
|
* limitation check done by Windows APIs. It does so by normalizing the passed
|
|
* in filename or path 'in' to its full canonical path, and if that path is
|
|
* longer than MAX_PATH then setting 'out' to "\\?\" prefix + that full path.
|
|
*
|
|
* For example 'in' filename255chars in current directory C:\foo\bar is
|
|
* fixed as \\?\C:\foo\bar\filename255chars for 'out' which will tell Windows
|
|
* it is ok to access that filename even though the actual full path is longer
|
|
* than 260 chars.
|
|
*
|
|
* For non-Unicode builds this function may fail sometimes because only the
|
|
* Unicode versions of some Windows API functions can access paths longer than
|
|
* MAX_PATH, for example GetFullPathNameW which is used in this function. When
|
|
* the full path is then converted from Unicode to multibyte that fails if any
|
|
* directories in the path contain characters not in the current codepage.
|
|
*/
|
|
static bool fix_excessive_path(const TCHAR *in, TCHAR **out)
|
|
{
|
|
size_t needed, count;
|
|
const wchar_t *in_w;
|
|
wchar_t *fbuf = NULL;
|
|
|
|
/* MS documented "approximate" limit for the maximum path length */
|
|
const size_t max_path_len = 32767;
|
|
|
|
#ifndef _UNICODE
|
|
wchar_t *ibuf = NULL;
|
|
char *obuf = NULL;
|
|
#endif
|
|
|
|
*out = NULL;
|
|
|
|
/* skip paths already normalized */
|
|
if(!_tcsncmp(in, _T("\\\\?\\"), 4))
|
|
goto cleanup;
|
|
|
|
#ifndef _UNICODE
|
|
/* convert multibyte input to unicode */
|
|
if(mbstowcs_s(&needed, NULL, 0, in, 0))
|
|
goto cleanup;
|
|
if(!needed || needed >= max_path_len)
|
|
goto cleanup;
|
|
ibuf = CURLX_MALLOC(needed * sizeof(wchar_t));
|
|
if(!ibuf)
|
|
goto cleanup;
|
|
if(mbstowcs_s(&count, ibuf, needed, in, needed - 1))
|
|
goto cleanup;
|
|
if(count != needed)
|
|
goto cleanup;
|
|
in_w = ibuf;
|
|
#else
|
|
in_w = in;
|
|
#endif
|
|
|
|
/* GetFullPathNameW returns the normalized full path in unicode. It converts
|
|
forward slashes to backslashes, processes .. to remove directory segments,
|
|
etc. Unlike GetFullPathNameA it can process paths that exceed MAX_PATH. */
|
|
needed = (size_t)GetFullPathNameW(in_w, 0, NULL, NULL);
|
|
if(!needed || needed > max_path_len)
|
|
goto cleanup;
|
|
/* skip paths that are not excessive and do not need modification */
|
|
if(needed <= MAX_PATH)
|
|
goto cleanup;
|
|
fbuf = CURLX_MALLOC(needed * sizeof(wchar_t));
|
|
if(!fbuf)
|
|
goto cleanup;
|
|
count = (size_t)GetFullPathNameW(in_w, (DWORD)needed, fbuf, NULL);
|
|
if(!count || count >= needed)
|
|
goto cleanup;
|
|
|
|
/* prepend \\?\ or \\?\UNC\ to the excessively long path.
|
|
*
|
|
* c:\longpath ---> \\?\c:\longpath
|
|
* \\.\c:\longpath ---> \\?\c:\longpath
|
|
* \\?\c:\longpath ---> \\?\c:\longpath (unchanged)
|
|
* \\server\c$\longpath ---> \\?\UNC\server\c$\longpath
|
|
*
|
|
* https://learn.microsoft.com/dotnet/standard/io/file-path-formats
|
|
*/
|
|
if(!wcsncmp(fbuf, L"\\\\?\\", 4))
|
|
; /* do nothing */
|
|
else if(!wcsncmp(fbuf, L"\\\\.\\", 4))
|
|
fbuf[2] = '?';
|
|
else if(!wcsncmp(fbuf, L"\\\\.", 3) || !wcsncmp(fbuf, L"\\\\?", 3)) {
|
|
/* Unexpected, not UNC. The formatting doc does not allow this AFAICT. */
|
|
goto cleanup;
|
|
}
|
|
else {
|
|
wchar_t *temp;
|
|
|
|
if(!wcsncmp(fbuf, L"\\\\", 2)) {
|
|
/* "\\?\UNC\" + full path without "\\" + null */
|
|
needed = 8 + (count - 2) + 1;
|
|
if(needed > max_path_len)
|
|
goto cleanup;
|
|
|
|
temp = CURLX_MALLOC(needed * sizeof(wchar_t));
|
|
if(!temp)
|
|
goto cleanup;
|
|
|
|
if(wcsncpy_s(temp, needed, L"\\\\?\\UNC\\", 8)) {
|
|
CURLX_FREE(temp);
|
|
goto cleanup;
|
|
}
|
|
if(wcscpy_s(temp + 8, needed, fbuf + 2)) {
|
|
CURLX_FREE(temp);
|
|
goto cleanup;
|
|
}
|
|
}
|
|
else {
|
|
/* "\\?\" + full path + null */
|
|
needed = 4 + count + 1;
|
|
if(needed > max_path_len)
|
|
goto cleanup;
|
|
|
|
temp = CURLX_MALLOC(needed * sizeof(wchar_t));
|
|
if(!temp)
|
|
goto cleanup;
|
|
|
|
if(wcsncpy_s(temp, needed, L"\\\\?\\", 4)) {
|
|
CURLX_FREE(temp);
|
|
goto cleanup;
|
|
}
|
|
if(wcscpy_s(temp + 4, needed, fbuf)) {
|
|
CURLX_FREE(temp);
|
|
goto cleanup;
|
|
}
|
|
}
|
|
|
|
CURLX_FREE(fbuf);
|
|
fbuf = temp;
|
|
}
|
|
|
|
#ifndef _UNICODE
|
|
/* convert unicode full path to multibyte output */
|
|
if(wcstombs_s(&needed, NULL, 0, fbuf, 0))
|
|
goto cleanup;
|
|
if(!needed || needed >= max_path_len)
|
|
goto cleanup;
|
|
obuf = CURLX_MALLOC(needed);
|
|
if(!obuf)
|
|
goto cleanup;
|
|
if(wcstombs_s(&count, obuf, needed, fbuf, needed - 1))
|
|
goto cleanup;
|
|
if(count != needed)
|
|
goto cleanup;
|
|
*out = obuf;
|
|
obuf = NULL;
|
|
#else
|
|
*out = fbuf;
|
|
fbuf = NULL;
|
|
#endif
|
|
|
|
cleanup:
|
|
CURLX_FREE(fbuf);
|
|
#ifndef _UNICODE
|
|
CURLX_FREE(ibuf);
|
|
CURLX_FREE(obuf);
|
|
#endif
|
|
return *out ? true : false;
|
|
}
|
|
|
|
#ifndef CURL_WINDOWS_UWP
|
|
HANDLE curlx_CreateFile(const char *filename,
|
|
DWORD dwDesiredAccess,
|
|
DWORD dwShareMode,
|
|
LPSECURITY_ATTRIBUTES lpSecurityAttributes,
|
|
DWORD dwCreationDisposition,
|
|
DWORD dwFlagsAndAttributes,
|
|
HANDLE hTemplateFile)
|
|
{
|
|
HANDLE handle = INVALID_HANDLE_VALUE;
|
|
|
|
#ifdef UNICODE
|
|
TCHAR *filename_t = curlx_convert_UTF8_to_wchar(filename);
|
|
#else
|
|
const TCHAR *filename_t = filename;
|
|
#endif
|
|
|
|
if(filename_t) {
|
|
TCHAR *fixed = NULL;
|
|
const TCHAR *target = NULL;
|
|
|
|
if(fix_excessive_path(filename_t, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename_t;
|
|
/* !checksrc! disable BANNEDFUNC 1 */
|
|
handle = CreateFile(target,
|
|
dwDesiredAccess,
|
|
dwShareMode,
|
|
lpSecurityAttributes,
|
|
dwCreationDisposition,
|
|
dwFlagsAndAttributes,
|
|
hTemplateFile);
|
|
CURLX_FREE(fixed);
|
|
#ifdef UNICODE
|
|
curlx_free(filename_t);
|
|
#endif
|
|
}
|
|
|
|
return handle;
|
|
}
|
|
#endif /* !CURL_WINDOWS_UWP */
|
|
|
|
int curlx_win32_open(const char *filename, int oflag, ...)
|
|
{
|
|
int pmode = 0;
|
|
int result = -1;
|
|
TCHAR *fixed = NULL;
|
|
const TCHAR *target = NULL;
|
|
|
|
#ifdef _UNICODE
|
|
wchar_t *filename_w = fn_convert_UTF8_to_wchar(filename);
|
|
#endif
|
|
|
|
va_list param;
|
|
va_start(param, oflag);
|
|
if(oflag & O_CREAT)
|
|
pmode = va_arg(param, int);
|
|
va_end(param);
|
|
|
|
#ifdef _UNICODE
|
|
if(filename_w) {
|
|
if(fix_excessive_path(filename_w, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename_w;
|
|
errno = _wsopen_s(&result, target, oflag, _SH_DENYNO, pmode);
|
|
CURLX_FREE(filename_w);
|
|
}
|
|
else
|
|
/* !checksrc! disable ERRNOVAR 1 */
|
|
errno = EINVAL;
|
|
#else
|
|
if(fix_excessive_path(filename, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename;
|
|
errno = _sopen_s(&result, target, oflag, _SH_DENYNO, pmode);
|
|
#endif
|
|
|
|
CURLX_FREE(fixed);
|
|
return result;
|
|
}
|
|
|
|
FILE *curlx_win32_fopen(const char *filename, const char *mode)
|
|
{
|
|
FILE *result = NULL;
|
|
TCHAR *fixed = NULL;
|
|
const TCHAR *target = NULL;
|
|
|
|
#ifdef _UNICODE
|
|
wchar_t *filename_w = fn_convert_UTF8_to_wchar(filename);
|
|
wchar_t *mode_w = fn_convert_UTF8_to_wchar(mode);
|
|
if(filename_w && mode_w) {
|
|
if(fix_excessive_path(filename_w, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename_w;
|
|
result = _wfsopen(target, mode_w, _SH_DENYNO);
|
|
}
|
|
else
|
|
/* !checksrc! disable ERRNOVAR 1 */
|
|
errno = EINVAL;
|
|
CURLX_FREE(filename_w);
|
|
CURLX_FREE(mode_w);
|
|
#else
|
|
if(fix_excessive_path(filename, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename;
|
|
result = _fsopen(target, mode, _SH_DENYNO);
|
|
#endif
|
|
|
|
CURLX_FREE(fixed);
|
|
return result;
|
|
}
|
|
|
|
#if defined(__MINGW32__) && (__MINGW64_VERSION_MAJOR < 5)
|
|
_CRTIMP errno_t __cdecl freopen_s(FILE **file, const char *filename,
|
|
const char *mode, FILE *stream);
|
|
#endif
|
|
|
|
FILE *curlx_win32_freopen(const char *filename, const char *mode, FILE *fp)
|
|
{
|
|
FILE *result = NULL;
|
|
TCHAR *fixed = NULL;
|
|
const TCHAR *target = NULL;
|
|
|
|
#ifdef _UNICODE
|
|
wchar_t *filename_w = fn_convert_UTF8_to_wchar(filename);
|
|
wchar_t *mode_w = fn_convert_UTF8_to_wchar(mode);
|
|
if(filename_w && mode_w) {
|
|
if(fix_excessive_path(filename_w, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename_w;
|
|
errno = _wfreopen_s(&result, target, mode_w, fp);
|
|
}
|
|
else
|
|
/* !checksrc! disable ERRNOVAR 1 */
|
|
errno = EINVAL;
|
|
CURLX_FREE(filename_w);
|
|
CURLX_FREE(mode_w);
|
|
#else
|
|
if(fix_excessive_path(filename, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = filename;
|
|
errno = freopen_s(&result, target, mode, fp);
|
|
#endif
|
|
|
|
CURLX_FREE(fixed);
|
|
return result;
|
|
}
|
|
|
|
int curlx_win32_stat(const char *path, struct_stat *buffer)
|
|
{
|
|
int result = -1;
|
|
TCHAR *fixed = NULL;
|
|
const TCHAR *target = NULL;
|
|
|
|
#ifdef _UNICODE
|
|
wchar_t *path_w = curlx_convert_UTF8_to_wchar(path);
|
|
if(path_w) {
|
|
if(fix_excessive_path(path_w, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = path_w;
|
|
result = _wstati64(target, buffer);
|
|
curlx_free(path_w);
|
|
}
|
|
else
|
|
/* !checksrc! disable ERRNOVAR 1 */
|
|
errno = EINVAL;
|
|
#else
|
|
if(fix_excessive_path(path, &fixed))
|
|
target = fixed;
|
|
else
|
|
target = path;
|
|
result = _stati64(target, buffer);
|
|
#endif
|
|
|
|
CURLX_FREE(fixed);
|
|
return result;
|
|
}
|
|
|
|
#if !defined(CURL_DISABLE_HTTP) || !defined(CURL_DISABLE_COOKIES) || \
|
|
!defined(CURL_DISABLE_ALTSVC)
|
|
/* rename() on Windows does not overwrite, so we cannot use it here.
|
|
MoveFileEx() will overwrite and is usually atomic, however it fails
|
|
when there are open handles to the file. */
|
|
int curlx_win32_rename(const char *oldpath, const char *newpath)
|
|
{
|
|
int res = -1; /* fail */
|
|
|
|
#ifdef UNICODE
|
|
TCHAR *tchar_oldpath = curlx_convert_UTF8_to_wchar(oldpath);
|
|
TCHAR *tchar_newpath = curlx_convert_UTF8_to_wchar(newpath);
|
|
#else
|
|
const TCHAR *tchar_oldpath = oldpath;
|
|
const TCHAR *tchar_newpath = newpath;
|
|
#endif
|
|
|
|
if(tchar_oldpath && tchar_newpath) {
|
|
const int max_wait_ms = 1000;
|
|
struct curltime start;
|
|
|
|
TCHAR *oldpath_fixed = NULL;
|
|
TCHAR *newpath_fixed = NULL;
|
|
const TCHAR *target_oldpath;
|
|
const TCHAR *target_newpath;
|
|
|
|
if(fix_excessive_path(tchar_oldpath, &oldpath_fixed))
|
|
target_oldpath = oldpath_fixed;
|
|
else
|
|
target_oldpath = tchar_oldpath;
|
|
|
|
if(fix_excessive_path(tchar_newpath, &newpath_fixed))
|
|
target_newpath = newpath_fixed;
|
|
else
|
|
target_newpath = tchar_newpath;
|
|
|
|
start = curlx_now();
|
|
|
|
for(;;) {
|
|
timediff_t diff;
|
|
/* !checksrc! disable BANNEDFUNC 1 */
|
|
if(MoveFileEx(target_oldpath, target_newpath,
|
|
MOVEFILE_REPLACE_EXISTING)) {
|
|
res = 0; /* success */
|
|
break;
|
|
}
|
|
diff = curlx_timediff_ms(curlx_now(), start);
|
|
if(diff < 0 || diff > max_wait_ms) {
|
|
break;
|
|
}
|
|
Sleep(1);
|
|
}
|
|
|
|
CURLX_FREE(oldpath_fixed);
|
|
CURLX_FREE(newpath_fixed);
|
|
}
|
|
|
|
#ifdef UNICODE
|
|
curlx_free(tchar_oldpath);
|
|
curlx_free(tchar_newpath);
|
|
#endif
|
|
|
|
return res;
|
|
}
|
|
#endif
|
|
|
|
#undef CURLX_MALLOC
|
|
#undef CURLX_FREE
|
|
|
|
#endif /* _WIN32 */
|