mirror/dash
1
0
Fork 0
mirror of https://salsa.debian.org/debian/dash.git synced 2026-01-27 09:54:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

redir: Fix double close in dupredirect

Browse Source 
For a redirection like "> /dev/null" dupredirect will close the
newly opened file descriptor twice in a row because sh_dup2 also
closes the new file descriptor.

Remove the extra close in dupredirect.

Fixes: 509f5b0dcd71 ("redir: Use memfd_create instead of pipe")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Herbert Xu 2024-05-04 15:21:22 +08:00
parent 257f6b36b8
commit ea5e24281a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/redir.c
View File

@ -319,11 +319,9 @@ static void dupredirect(union node *redir, int f)
sh_dup2(f, fd, -1);
return;
}
f = fd;
close(fd);
} else
sh_dup2(f, fd, f);
close(f);
}
int sh_pipe(int pip[2], int memfd)