mirror/groff
1
0
Fork 0
mirror of https://https.git.savannah.gnu.org/git/groff.git synced 2026-01-26 15:39:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[pre-grohtml]: Clear heap-allocated memory.

Browse Source 
* src/preproc/html/pre-html.cpp (get_line): Clear heap-allocated memory
  and annotate how we could do so in-language in C++03.
This commit is contained in:
G. Branden Robinson 2025-07-30 19:35:03 -05:00
parent 1c8c8f4fc7
commit 6af159cc03
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2025-07-30 G. Branden Robinson <g.branden.robinson@gmail.com>
* src/preproc/html/pre-html.cpp (get_line): Clear heap-allocated
memory and annotate how we could do so in-language in C++03.
2025-07-30 G. Branden Robinson <g.branden.robinson@gmail.com>
* src/preproc/html/pre-html.cpp (get_resolution)

10
src/preproc/html/pre-html.cpp
View File

@ -262,6 +262,10 @@ void sys_fatal(const char *s)
/*
* get_line - Copy a line (w/o newline) from a file to the
* global line buffer.
*
* TODO: Discard; migrate callers to POSIX `getline()`.
* https://pubs.opengroup.org/onlinepubs/9799919799/functions/\
* getline.html
*/
static bool get_line(FILE *f, const char *file_name, int lineno)
@ -271,7 +275,8 @@ static bool get_line(FILE *f, const char *file_name, int lineno)
if (0 /* nullptr */ == linebuf) {
linebufsize = 128;
try {
linebuf = new char[linebufsize];
linebuf = new char[linebufsize]; // C++03: new int[linebufsize]();
(void) memset(linebuf, '\0', (linebufsize * sizeof(char)));
}
catch (std::bad_alloc &e) {
fatal_with_file_and_line(file_name, lineno, "cannot allocate %1"
@ -298,7 +303,8 @@ static bool get_line(FILE *f, const char *file_name, int lineno)
int newbufsize = linebufsize * 2;
char *old_linebuf = linebuf;
try {
linebuf = new char[newbufsize];
linebuf = new char[newbufsize]; // C++03: new int[newbufsize]();
(void) memset(linebuf, '\0', (newbufsize * sizeof(char)));
}
catch (std::bad_alloc &e) {
fatal_with_file_and_line(file_name, lineno, "cannot allocate"