Emil Taylor Bye 2263d6037f
Fix closures using FFI_REGISTER ABI (#949)
* Fix closures using FFI_REGISTER ABI

ffi_closure_REGISTER had the positions of the closure and return address
switched, resulting in a segfault when calling a closure created with
the FFI_REGISTER ABI.

* Fix comment and remove redundant assembly

* After fixing closures using FFI_REGISTER ABI, the comments were
  incorrect, not reflecting the value that was actually loaded into eax
  and ecx.
* Additionally, ecx was loaded with the data at esp + closure_FS only
  to write it back to esp + closure_FS. Both commands were removed as
  they end up not having any effect as ecx is overwritten during
  FFI_CLOSURE_COPY_TRAMP_DATA.
2025-12-26 10:04:51 -05:00
..
2017-04-27 13:22:28 +02:00
2024-09-15 07:39:01 -04:00
2017-04-27 13:22:28 +02:00
2020-06-29 08:04:45 -04:00
2018-09-18 15:19:53 +02:00
2023-09-04 07:27:01 -04:00
2022-05-29 10:12:30 -04:00
2017-04-27 13:22:28 +02:00
2017-04-27 13:22:28 +02:00
2018-09-18 15:19:53 +02:00
2017-04-27 13:22:28 +02:00
2024-09-15 07:22:36 -04:00
2013-10-08 06:45:51 -04:00
2012-03-19 23:07:35 -04:00
2024-06-28 04:07:09 -04:00
2013-10-08 06:45:51 -04:00
2017-04-27 13:22:28 +02:00
2025-08-02 02:28:46 -04:00
2023-12-22 05:30:50 -05:00
2017-04-27 13:22:28 +02:00
2025-02-08 11:32:05 -05:00
2017-04-27 13:22:28 +02:00
2025-08-02 08:52:25 +02:00