mirror of
https://github.com/Shopify/liquid.git
synced 2026-01-27 20:44:25 +00:00
32b50ecafe
This commit reverts the Inline Snippets tag (#2001) and bumps Liquid to 5.11. For now, the inclusion of Inline Snippets in the latest Liquid release is being treated as a bug. While #2001 does implement the scope contained in RFC#1916, we need to take a step back to make sure we’re setting our sights high enough with this feature, and that we’re truly supporting theme developers in the ways they need. If you have any feedback, please leave a comment on RFC#1916. - Liquid Developer Tools
124 lines
4.0 KiB
Ruby
124 lines
4.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'test_helper'
|
|
|
|
class ParseContextUnitTest < Minitest::Test
|
|
include Liquid
|
|
|
|
def test_safe_parse_expression_with_variable_lookup
|
|
parser_strict = strict_parse_context.new_parser('product.title')
|
|
result_strict = strict_parse_context.safe_parse_expression(parser_strict)
|
|
|
|
parser_strict2 = strict2_parse_context.new_parser('product.title')
|
|
result_strict2 = strict2_parse_context.safe_parse_expression(parser_strict2)
|
|
|
|
assert_instance_of(VariableLookup, result_strict)
|
|
assert_equal('product', result_strict.name)
|
|
assert_equal(['title'], result_strict.lookups)
|
|
|
|
assert_instance_of(VariableLookup, result_strict2)
|
|
assert_equal('product', result_strict2.name)
|
|
assert_equal(['title'], result_strict2.lookups)
|
|
end
|
|
|
|
def test_safe_parse_expression_raises_syntax_error_for_invalid_expression
|
|
parser_strict = strict_parse_context.new_parser('')
|
|
parser_strict2 = strict2_parse_context.new_parser('')
|
|
|
|
error_strict = assert_raises(Liquid::SyntaxError) do
|
|
strict_parse_context.safe_parse_expression(parser_strict)
|
|
end
|
|
assert_match(/is not a valid expression/, error_strict.message)
|
|
|
|
error_strict2 = assert_raises(Liquid::SyntaxError) do
|
|
strict2_parse_context.safe_parse_expression(parser_strict2)
|
|
end
|
|
|
|
assert_match(/is not a valid expression/, error_strict2.message)
|
|
end
|
|
|
|
def test_parse_expression_with_variable_lookup
|
|
result_strict = strict_parse_context.parse_expression('product.title')
|
|
|
|
assert_instance_of(VariableLookup, result_strict)
|
|
assert_equal('product', result_strict.name)
|
|
assert_equal(['title'], result_strict.lookups)
|
|
|
|
error = assert_raises(Liquid::InternalError) do
|
|
strict2_parse_context.parse_expression('product.title')
|
|
end
|
|
|
|
assert_match(/unsafe parse_expression cannot be used in strict2 mode/, error.message)
|
|
end
|
|
|
|
def test_parse_expression_with_safe_true
|
|
result_strict = strict_parse_context.parse_expression('product.title', safe: true)
|
|
|
|
assert_instance_of(VariableLookup, result_strict)
|
|
assert_equal('product', result_strict.name)
|
|
assert_equal(['title'], result_strict.lookups)
|
|
|
|
result_strict2 = strict2_parse_context.parse_expression('product.title', safe: true)
|
|
|
|
assert_instance_of(VariableLookup, result_strict2)
|
|
assert_equal('product', result_strict2.name)
|
|
assert_equal(['title'], result_strict2.lookups)
|
|
end
|
|
|
|
def test_parse_expression_with_empty_string
|
|
result_strict = strict_parse_context.parse_expression('')
|
|
assert_nil(result_strict)
|
|
|
|
error = assert_raises(Liquid::InternalError) do
|
|
strict2_parse_context.parse_expression('')
|
|
end
|
|
|
|
assert_match(/unsafe parse_expression cannot be used in strict2 mode/, error.message)
|
|
end
|
|
|
|
def test_parse_expression_with_empty_string_and_safe_true
|
|
result_strict = strict_parse_context.parse_expression('', safe: true)
|
|
assert_nil(result_strict)
|
|
|
|
result_strict2 = strict2_parse_context.parse_expression('', safe: true)
|
|
assert_nil(result_strict2)
|
|
end
|
|
|
|
def test_safe_parse_expression_advances_parser_pointer
|
|
parser = strict2_parse_context.new_parser('foo, bar')
|
|
|
|
# safe_parse_expression consumes "foo"
|
|
first_result = strict2_parse_context.safe_parse_expression(parser)
|
|
assert_instance_of(VariableLookup, first_result)
|
|
assert_equal('foo', first_result.name)
|
|
|
|
parser.consume(:comma)
|
|
|
|
# safe_parse_expression consumes "bar"
|
|
second_result = strict2_parse_context.safe_parse_expression(parser)
|
|
assert_instance_of(VariableLookup, second_result)
|
|
assert_equal('bar', second_result.name)
|
|
|
|
parser.consume(:end_of_string)
|
|
end
|
|
|
|
def test_parse_expression_with_whitespace_in_strict2_mode
|
|
result = strict2_parse_context.parse_expression(' ', safe: true)
|
|
assert_nil(result)
|
|
end
|
|
|
|
private
|
|
|
|
def strict_parse_context
|
|
@strict_parse_context ||= ParseContext.new(
|
|
environment: Environment.build(error_mode: :strict),
|
|
)
|
|
end
|
|
|
|
def strict2_parse_context
|
|
@strict2_parse_context ||= ParseContext.new(
|
|
environment: Environment.build(error_mode: :strict2),
|
|
)
|
|
end
|
|
end
|