mirror/perl
1
0
Fork 0
mirror of https://github.com/Perl/perl5.git synced 2026-01-26 16:39:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

GDBM_File: fix fetching mmapsize

Browse Source 
Originally this came up from a Coverity complaint.

GDBM_SETMAXMAPSIZE accepts any of unsigned, unsigned long or size_t,
but GDBM_GETMAXMAPSIZE only accepts size_t.  Since this is the only
case that uses unsigned values we can safely switch it to size_t.

Unfortunately Coverity's analysis was pretty broken, it complained
about c_uv being uninitialised at the call to newSVuv, but its example
code flow went through the opt_dbname case, which sets vptr to != &c_uv
so the newSVuv() wouldn't execute anyway.

Before looking closely at the Coverity analysis and after finding the
bug fixed here I thought for a moment that Coverity had been tracing
into libgdbm, which could have caught the actual problem, but alas
that was not the case.

I expect this fix will not close CID 351943, and if it remains after
this is applied I'll close it as a false positive.

CID 351943.
This commit is contained in:
Tony Cook 2022-06-02 11:01:44 +10:00
parent a1f822c22a
commit 34e6e2fba7
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/GDBM_File/GDBM_File.xs
View File

@ -878,7 +878,7 @@ gdbm_flags(db, ...)
PREINIT:
int opcode = -1;
int c_iv;
unsigned c_uv;
size_t c_uv;
char *c_cv;
OPTVALPTR vptr = (OPTVALPTR) &c_iv;
size_t vsiz = sizeof(c_iv);

7
ext/GDBM_File/t/opt.t
View File

@ -14,7 +14,7 @@ BEGIN {
plan(skip_all => "GDBM_File is flaky in $^O")
if $^O =~ /darwin/;
plan(tests => 8);
plan(tests => 9);
use_ok('GDBM_File');
}
@ -34,4 +34,9 @@ SKIP: {
is($db->sync_mode, 0, 'get sync_mode');
is($db->sync_mode(1), 1, 'set sync_mode');
is($db->sync_mode, 1, 'get sync_mode');
SKIP: {
my ($maj, $min) = GDBM_File->GDBM_version;
skip "gdbm too old", 1 if $maj != 1 || $maj == 1 && $min < 9;
isnt($db->mmapsize, 0, "get mmapsize");
}
}