mirror/perl
1
0
Fork 0
mirror of https://github.com/Perl/perl5.git synced 2026-01-26 08:38:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Nuke the MGf_PERSIST flag, freeing a bit in ->mg_flags

Browse Source 
The MGf_PERSIST flag is only used by PERL_MAGIC_lvref, and there it
simply contains a shadow copy of the OPpLVREF_ITER flag in op_private.
Since the mg_priv field is set as a copy of op_private anyway, the code
that checks this bit might as well look there instead.

As a result of this change, the 0x80 bit of the mg_flags field is now
free for other purposes.
This commit is contained in:
Paul "LeoNerd" Evans 2025-03-27 13:10:25 +00:00 committed by Paul Evans
parent 52fdca79c1
commit 6d97c8623f
3 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mg.c
View File

@ -2899,7 +2899,7 @@ Perl_magic_setlvref(pTHX_ SV *sv, MAGIC *mg)
(void)hv_store_ent((HV *)mg->mg_obj, (SV *)mg->mg_ptr,
SvREFCNT_inc_simple_NN(SvRV(sv)), 0);
}
if (mg->mg_flags & MGf_PERSIST)
if (mg->mg_private & OPpLVREF_ITER)
NOOP; /* This sv is in use as an iterator var and will be reused,
so we must leave the magic. */
else

1
mg.h
View File

@ -40,7 +40,6 @@ struct magic {
#define MGf_DUP 0x10 /* has an svt_dup MGVTBL entry */
#define MGf_LOCAL 0x20 /* has an svt_local MGVTBL entry */
#define MGf_BYTES 0x40 /* PERL_MAGIC_regex_global only */
#define MGf_PERSIST 0x80 /* PERL_MAGIC_lvref only */
#define MgTAINTEDDIR(mg) (mg->mg_flags & MGf_TAINTEDDIR)
#define MgTAINTEDDIR_on(mg) (mg->mg_flags |= MGf_TAINTEDDIR)

2
pp.c
View File

@ -7598,8 +7598,6 @@ PP_wrapped(pp_lvref,
&PL_vtbl_lvref, (char *)elem,
elem ? HEf_SVKEY : (I32)ARGTARG);
mg->mg_private = PL_op->op_private;
if (PL_op->op_private & OPpLVREF_ITER)
mg->mg_flags |= MGf_PERSIST;
if (UNLIKELY(PL_op->op_private & OPpLVAL_INTRO)) {
if (elem) {
assert(arg);