mirror/perl
1
0
Fork 0
mirror of https://github.com/Perl/perl5.git synced 2026-01-26 16:39:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

XSUB.h: simplify XS_INTERNAL/XS_EXTERNAL macros

Browse Source 
Ever since `__attribute__unused__` was added to the XSPROTO definition,
the explicit `defined(HASATTRIBUTE_UNUSED)` check has become redundant.

Also, the XS_INTERNAL definitions are functionally equivalent in all
branches, so replace them by a single unconditional definition.
This commit is contained in:
Lukas Mai 2025-01-06 06:45:04 +01:00 committed by mauke
parent bc21a71a5f
commit 7911101dcf
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
XSUB.h
View File

@ -122,9 +122,6 @@ is a lexical C<$_> in scope.
* typedef SwigPerlWrapper *SwigPerlWrapperPtr;
*
* This code needs to be compilable under both C and C++.
*
* Don't forget to change the __attribute__unused__ version of XS()
* below too if you change XSPROTO() here.
*/
/* XS_INTERNAL is the explicit static-linkage variant of the default
@ -141,17 +138,12 @@ is a lexical C<$_> in scope.
#undef XS_INTERNAL
#if defined(__CYGWIN__) && defined(USE_DYNAMIC_LOADING)
# define XS_EXTERNAL(name) __declspec(dllexport) XSPROTO(name)
# define XS_INTERNAL(name) STATIC XSPROTO(name)
#elif defined(__cplusplus)
# define XS_EXTERNAL(name) extern "C" XSPROTO(name)
# define XS_INTERNAL(name) static XSPROTO(name)
#elif defined(HASATTRIBUTE_UNUSED)
# define XS_EXTERNAL(name) void name(pTHX_ CV* cv __attribute__unused__)
# define XS_INTERNAL(name) STATIC void name(pTHX_ CV* cv __attribute__unused__)
#else
# define XS_EXTERNAL(name) XSPROTO(name)
# define XS_INTERNAL(name) STATIC XSPROTO(name)
#endif
#define XS_INTERNAL(name) STATIC XSPROTO(name)
/* We do export xsub symbols by default for the public XS macro.
* Try explicitly using XS_INTERNAL/XS_EXTERNAL instead, please. */