mirror/perl
1
0
Fork 0
mirror of https://github.com/Perl/perl5.git synced 2026-01-27 01:44:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

newAVav - av_push_simple for faster ret array assignment

Browse Source
This commit is contained in:
Richard Leach 2022-07-14 11:46:33 +00:00 committed by Paul Evans
parent 3b6b0454f7
commit 80c024ac46
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
av.c
View File

@ -466,15 +466,11 @@ Perl_newAVav(pTHX_ AV *oav)
{
PERL_ARGS_ASSERT_NEWAVAV;
U32 count = av_count(oav);
Size_t count = av_count(oav);
if(UNLIKELY(!oav) || count == 0)
return newAV();
if(LIKELY(!SvRMAGICAL(oav))) {
return av_make(av_count(oav), AvARRAY(oav));
}
AV *ret = newAV_alloc_x(count);
/* avoid ret being leaked if croak when calling magic below */
@ -482,9 +478,17 @@ Perl_newAVav(pTHX_ AV *oav)
PL_tmps_stack[++PL_tmps_ix] = (SV *)ret;
SSize_t ret_at_tmps_ix = PL_tmps_ix;
for(U32 i = 0; i < count; i++) {
SV **svp = av_fetch(oav, i, 0);
av_push(ret, svp ? newSVsv(*svp) : &PL_sv_undef);
Size_t i;
if(LIKELY(!SvRMAGICAL(oav) && AvREAL(oav) && (SvTYPE(oav) == SVt_PVAV))) {
for(i = 0; i < count; i++) {
SV **svp = av_fetch_simple(oav, i, 0);
av_push_simple(ret, svp ? newSVsv(*svp) : &PL_sv_undef);
}
} else {
for(i = 0; i < count; i++) {
SV **svp = av_fetch(oav, i, 0);
av_push_simple(ret, svp ? newSVsv(*svp) : &PL_sv_undef);
}
}
/* disarm leak guard */