mirror/perl
1
0
Fork 0
mirror of https://github.com/Perl/perl5.git synced 2026-01-26 16:39:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

embed.pl: Rename variable

Browse Source 
The new name adds the detail as to what it constrains
This commit is contained in:
Karl Williamson 2025-12-14 02:14:32 -07:00 committed by Karl Williamson
parent aa3eb59ab9
commit f210eba1a5
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
regen/embed.pl
View File

@ -4717,22 +4717,23 @@ sub find_undefs {
# evaluate, as a whole, to false or not. We don't know the value of many
# of the conditions, but generally, the ones that guard visibility will be
# enough to rule out a symbol being globally visible.
my %constraints;
my %cpp_ifdef_constraints;
for my $c (@c_list) {
my $c_prime = $c =~ s/[.]/_/r;
$constraints{ "PERL_IN_\U$c_prime" } = 0;
$cpp_ifdef_constraints{ "PERL_IN_\U$c_prime" } = 0;
}
# There are also these three symbols that guard visibility. A symbol that
# is visible when all three are 0, is globally visible.
$constraints{PERL_CORE} = 0;
$constraints{PERL_EXT} = 0;
$constraints{PERL_EXT_RE_BUILD} = 0;
$cpp_ifdef_constraints{PERL_CORE} = 0;
$cpp_ifdef_constraints{PERL_EXT} = 0;
$cpp_ifdef_constraints{PERL_EXT_RE_BUILD} = 0;
# Match any of these. HeaderParser creates this canonical form for all
# conditionals.
my $constraints_re = join "|", keys %constraints;
$constraints_re = qr/ \b defined \( ( $constraints_re ) \) /x;
my $cpp_ifdef_constraints_re = join "|", keys %cpp_ifdef_constraints;
$cpp_ifdef_constraints_re =
qr/ \b defined \( ( $cpp_ifdef_constraints_re ) \) /x;
# There are a few cases where we redefine a system function to use the
# 64-bit equivalent one that has a different name. They currenty all look
@ -4768,8 +4769,8 @@ sub find_undefs {
next if $name =~ / ^ PL_ /x;
next if $name =~ /perl/i;
next unless $line->reduce_conds($constraints_re,
\%constraints);
next unless $line->reduce_conds($cpp_ifdef_constraints_re,
\%cpp_ifdef_constraints);
# Often perl has code to make sure various symbols that are
# always expected by the system to be defined, in fact are.