mirror/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2026-01-27 04:24:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ruby/rubygems] Undeprecate Gem::Version#<=> against strings

Browse Source 
This pattern is extremely common across the ecosystem, I don't think
it's reasonable to deprecate it.

I understand the performance argument, but perhaps the dependency
resolution algorithm can use another method that is private API
and only works with two `Version` instance.

https://github.com/ruby/rubygems/commit/024b4b547a
This commit is contained in:
Jean Boussier 2025-11-21 19:30:04 +01:00 committed by git
parent 6e2906f60d
commit 2289961b48
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/rubygems/version.rb
View File

@ -344,9 +344,6 @@ class Gem::Version
def <=>(other)
if String === other
unless Gem::Deprecate.skip
warn "comparing version objects with strings is deprecated and will be removed", uplevel: 1
end
return unless self.class.correct?(other)
return self <=> self.class.new(other)
end

6
test/rubygems/test_gem_version.rb
View File

@ -160,11 +160,7 @@ class TestGemVersion < Gem::TestCase
[-1, "1.9.3.1"],
[nil, "whatever"],
].each do |cmp, string_ver|
actual_stdout, actual_stderr = capture_output do
assert_equal(cmp, v("1.9.3") <=> string_ver)
end
assert_empty actual_stdout
assert_match(/comparing version objects with strings is deprecated and will be removed/, actual_stderr)
assert_equal(cmp, v("1.9.3") <=> string_ver)
end
end