mirror/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2026-01-27 04:24:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

ZJIT: mem::take instead of drain then collect

Browse Source 
Gets rid of one transient vec copy/allocation.
This commit is contained in:
Alan Wu 2025-10-14 14:21:59 -04:00
parent d1442727dd
commit 8baf170e93
Notes: git 2025-10-14 19:02:09 +00:00 
Merged: https://github.com/ruby/ruby/pull/14835
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zjit/src/hir.rs
View File

@ -2398,7 +2398,7 @@ impl Function {
if let Some(replacement) = (props.inline)(fun, tmp_block, recv, &args, state) {
// Copy contents of tmp_block to block
assert_ne!(block, tmp_block);
let insns = fun.blocks[tmp_block.0].insns.drain(..).collect::<Vec<_>>();
let insns = std::mem::take(&mut fun.blocks[tmp_block.0].insns);
fun.blocks[block.0].insns.extend(insns);
fun.make_equal_to(send_insn_id, replacement);
fun.remove_block(tmp_block);
@ -2453,7 +2453,7 @@ impl Function {
if let Some(replacement) = (props.inline)(fun, tmp_block, recv, &args, state) {
// Copy contents of tmp_block to block
assert_ne!(block, tmp_block);
let insns = fun.blocks[tmp_block.0].insns.drain(..).collect::<Vec<_>>();
let insns = std::mem::take(&mut fun.blocks[tmp_block.0].insns);
fun.blocks[block.0].insns.extend(insns);
fun.make_equal_to(send_insn_id, replacement);
fun.remove_block(tmp_block);