mirror/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2026-01-27 04:24:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[rubygems/rubygems] remove some memoization

Browse Source 
I don't think these methods are hotspots, and since gem specifications
are sometimes serialized to yaml / marshal, I think we should remove as
many instance variables as possible

https://github.com/rubygems/rubygems/commit/40490d918b
This commit is contained in:
Aaron Patterson 2025-10-14 17:30:52 -07:00 committed by git
parent df5d63cfa2
commit 8d43867802
1 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/rubygems/specification.rb
View File

@ -488,8 +488,6 @@ class Gem::Specification < Gem::BasicSpecification
end
@platform = @new_platform.to_s
invalidate_memoized_attributes
end
##
@ -1620,14 +1618,14 @@ class Gem::Specification < Gem::BasicSpecification
# spec's cached gem.
def cache_dir
@cache_dir ||= File.join base_dir, "cache"
File.join base_dir, "cache"
end
##
# Returns the full path to the cached gem for this spec.
def cache_file
@cache_file ||= File.join cache_dir, "#{full_name}.gem"
File.join cache_dir, "#{full_name}.gem"
end
##
@ -1903,10 +1901,6 @@ class Gem::Specification < Gem::BasicSpecification
spec
end
def full_name
@full_name ||= super
end
##
# Work around old bundler versions removing my methods
# Can be removed once RubyGems can no longer install Bundler 2.5
@ -2044,17 +2038,6 @@ class Gem::Specification < Gem::BasicSpecification
end
end
##
# Expire memoized instance variables that can incorrectly generate, replace
# or miss files due changes in certain attributes used to compute them.
def invalidate_memoized_attributes
@full_name = nil
@cache_file = nil
end
private :invalidate_memoized_attributes
def inspect # :nodoc:
if $DEBUG
super
@ -2093,8 +2076,6 @@ class Gem::Specification < Gem::BasicSpecification
def internal_init # :nodoc:
super
@bin_dir = nil
@cache_dir = nil
@cache_file = nil
@doc_dir = nil
@ri_dir = nil
@spec_dir = nil
@ -2606,9 +2587,6 @@ class Gem::Specification < Gem::BasicSpecification
def version=(version)
@version = Gem::Version.create(version)
return if @version.nil?
invalidate_memoized_attributes
end
def stubbed?