mirror/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2026-01-26 12:14:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

YJIT: Fix --yjit-dump-insns by removing {cpush,cpop}_all() in printers

Browse Source 
cpush_all() and cpop_all() in theory enabled these `print_*` utilities
to work in more spots, but with automatically spilling in asm.ccall(),
the benefits are now limited. They also have a bug at the moment. Stop
using them to dodge the bug.
This commit is contained in:
Alan Wu 2026-01-13 23:08:33 -05:00
parent ac22989066
commit 9930468479
Notes: git 2026-01-14 22:20:26 +00:00 
Merged: https://github.com/ruby/ruby/pull/15831
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
yjit/src/utils.rs
View File

@ -160,8 +160,6 @@ pub fn print_int(asm: &mut Assembler, opnd: Opnd) {
}
}
asm.cpush_all();
let argument = match opnd {
Opnd::Mem(_) | Opnd::Reg(_) | Opnd::InsnOut { .. } => {
// Sign-extend the value if necessary
@ -176,7 +174,6 @@ pub fn print_int(asm: &mut Assembler, opnd: Opnd) {
};
asm.ccall(print_int_fn as *const u8, vec![argument]);
asm.cpop_all();
}
/// Generate code to print a pointer
@ -189,9 +186,7 @@ pub fn print_ptr(asm: &mut Assembler, opnd: Opnd) {
assert!(opnd.rm_num_bits() == 64);
asm.cpush_all();
asm.ccall(print_ptr_fn as *const u8, vec![opnd]);
asm.cpop_all();
}
/// Generate code to print a value
@ -204,9 +199,7 @@ pub fn print_value(asm: &mut Assembler, opnd: Opnd) {
assert!(matches!(opnd, Opnd::Value(_)));
asm.cpush_all();
asm.ccall(print_value_fn as *const u8, vec![opnd]);
asm.cpop_all();
}
/// Generate code to print constant string to stdout
@ -221,7 +214,6 @@ pub fn print_str(asm: &mut Assembler, str: &str) {
}
}
asm.cpush_all();
let string_data = asm.new_label("string_data");
let after_string = asm.new_label("after_string");
@ -233,8 +225,6 @@ pub fn print_str(asm: &mut Assembler, str: &str) {
let opnd = asm.lea_jump_target(string_data);
asm.ccall(print_str_cfun as *const u8, vec![opnd, Opnd::UImm(str.len() as u64)]);
asm.cpop_all();
}
pub fn stdout_supports_colors() -> bool {