mirror/ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2026-01-27 12:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

[PRISM] Fix CallNode with arguments when popped

Browse Source 
Previously emitting a call node with an argument followed by another
node would cause the argument to be mistakenly omitted from the argument
list causing a stack underflow.

```
PRISM: **************************************************
-- raw disasm--------
   0000 putself                                                          (   0)
   0001 send                 <calldata:puts, 1>, nil                     (   0)
*  0004 pop                                                              (   0)
   0005 putobject            1                                           (   0)
   0007 leave                                                            (   0)
---------------------
```
This commit is contained in:
Matt Valentine-House 2023-11-02 22:37:30 +00:00
parent 5cff4c5aa3
commit dcb9ded6c9
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
prism_compile.c
View File

@ -1403,7 +1403,7 @@ pm_setup_args(pm_arguments_node_t *arguments_node, int *flags, struct rb_callinf
default: {
orig_argc++;
post_splat_counter++;
PM_COMPILE(argument);
PM_COMPILE_NOT_POPPED(argument);
if (has_splat) {
// If the next node starts the keyword section of parameters

6
test/ruby/test_compile_prism.rb
View File

@ -694,6 +694,12 @@ module Prism
def test_CallNode
assert_prism_eval("to_s")
# with arguments
assert_prism_eval("eval '1'")
# with arguments and popped
assert_prism_eval("eval '1'; 1")
end
def test_CallAndWriteNode