normal feafe07874 webrick: do not hang acceptor on slow TLS connections ...

OpenSSL::SSL::SSLSocket#accept may block indefinitely on clients
which negotiate the TCP connection, but fail (or are slow) to
negotiate the subsequent TLS handshake.  This prevents the
multi-threaded WEBrick server from accepting other connections.

Since the TLS handshake (via OpenSSL::SSL::SSLSocket#accept)
consists of normal read/write traffic over TCP, handle it in the
per-client thread, instead.

Furthermore, using non-blocking accept() is useful for non-TLS
sockets anyways because spurious wakeups are possible from
select(2).

* lib/webrick/server.rb (accept_client): use TCPServer#accept_nonblock
  and remove OpenSSL::SSL::SSLSocket#accept call
* lib/webrick/server.rb (start_thread): call OpenSSL::SSL::SSLSocket#accept
* test/webrick/test_ssl_server.rb (test_slow_connect): new test
  [ruby-core:83221] [Bug #14005]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

2017-10-12 18:50:07 +00:00

..

bundler

Fixed broken bundle gem command.

2017-10-05 08:32:01 +00:00

cgi

Fix cgi/core code example missing comma

2017-08-02 15:10:38 +00:00

drb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

forwardable

forwardable/impl.rb

2016-11-20 02:12:48 +00:00

irb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

matrix

get rid of ambiguous parentheses warnings

2016-11-29 16:06:54 +00:00

net

Net::HTTP.new: Support no_proxy parameter [Feature #11195]

2017-09-28 10:51:37 +00:00

optparse

…

racc

Fix grammar errors

2016-11-08 19:55:59 +00:00

rdoc

* remove trailing spaces.

2017-10-10 02:01:01 +00:00

rexml

fix documentation of REXML::Formatters::Default (id_hack -> ie_hack) [ci skip]

2017-08-14 16:04:35 +00:00

rinda

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

rss

rss: Accept empty text element as valid element

2017-05-03 12:25:17 +00:00

rubygems

Merge rubygems-2.6.14 changes.

2017-10-10 08:58:22 +00:00

shell

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

unicode_normalize

update Ruby to Unicode 10.0.0

2017-09-06 07:56:41 +00:00

uri

URI::Generic: Separate no_proxy handling

2017-09-28 10:51:31 +00:00

webrick

webrick: do not hang acceptor on slow TLS connections

2017-10-12 18:50:07 +00:00

yaml

…

abbrev.rb

lib/abbrev.rb: Specify frozen_string_literal: true.

2017-02-09 16:12:00 +00:00

base64.rb

Use unpack1 instead of unpack and first

2017-02-10 00:58:47 +00:00

benchmark.rb

lib/benchmark.rb: Specify frozen_string_literal: true.

2017-01-03 02:00:01 +00:00

bundler.gemspec

Fixed broken bundle gem command.

2017-10-05 08:32:01 +00:00

bundler.rb

Merge bundler to standard libraries.

2017-09-08 08:45:41 +00:00

cgi.rb

{lib,test}/cgi: Specify frozen_string_literal: true.

2017-02-18 05:52:16 +00:00

cmath.gemspec

Update gemspec for gem released versions.

2017-09-14 02:01:36 +00:00

cmath.rb

lib/cmath.rb: Specify frozen_string_literal: true.

2017-01-04 05:47:52 +00:00

csv.gemspec

Merge csv-0.1.0 from upstream.

2017-09-12 08:38:06 +00:00

csv.rb

Merge csv-0.1.0 from upstream.

2017-09-12 08:38:06 +00:00

debug.rb

lib/debug.rb: Specify frozen_string_literal: true.

2017-01-05 01:00:01 +00:00

delegate.rb

Delegate to eql? [Fix GH-1564]

2017-06-24 03:35:29 +00:00

drb.rb

…

e2mmap.rb

lib/e2mmap.rb: Specify frozen_string_literal: true.

2017-03-01 11:37:30 +00:00

English.rb

$IGNORECASE is no longer effective. [ci skip]

2017-08-25 15:47:04 +00:00

erb.rb

Use unpack1 instead of unpack and [0]

2017-09-29 11:00:00 +00:00

fileutils.gemspec

Make string literal to frozen object on gemspec of defulte gems.

2017-06-19 13:03:06 +00:00

fileutils.rb

fileutils.rb: error at rmdir

2017-09-16 11:59:47 +00:00

find.rb

Find.find -> Use Dir.children instead of Dir.entries

2017-09-15 17:00:49 +00:00

forwardable.rb

forwardable.rb: fix branches

2017-01-03 09:47:16 +00:00

getoptlong.rb

getoptlong.rb: multiline regexps

2017-09-02 02:05:34 +00:00

ipaddr.gemspec

Extract files variables of ipaddr.gemspec for non git environment.

2017-08-16 09:45:58 +00:00

ipaddr.rb

IPAddr#== and IPAddr#<=> no longer raise an exception if coercion fails

2016-11-05 13:53:38 +00:00

irb.rb

Removed math mode from irb.

2017-04-20 09:11:36 +00:00

logger.rb

logger.rb: Fix handling progname

2017-07-20 16:47:26 +00:00

matrix.rb

* lib/matrix.rb: Add Vector.zero and Vector#zero?

2017-03-14 20:09:30 +00:00

mkmf.rb

mkmf.rb: get rid of error messages

2017-02-27 07:37:55 +00:00

monitor.rb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

mutex_m.rb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

observer.rb

lib/observer.rb: Specify frozen_string_literal: true.

2017-01-13 12:08:29 +00:00

open3.rb

lib/open3: favor symbol proc when possible

2016-11-21 23:13:16 +00:00

open-uri.rb

* lib/open-uri.rb: Improved documentation grammar for

2016-10-20 07:19:58 +00:00

optionparser.rb

…

optparse.rb

optparse.rb: case-sensitive candidate

2017-07-24 01:56:04 +00:00

ostruct.rb

ostruct.rb: improve fix for OpenStruct.allocate + #respond_to?

2017-04-01 10:30:48 +00:00

pp.rb

Refactored using Method#owner.

2017-04-04 12:54:42 +00:00

prettyprint.rb

…

prime.rb

prime.rb: remove alias after timeout test

2017-05-20 10:21:44 +00:00

profile.rb

lib/profile.rb: Specify frozen_string_literal: true.

2017-01-15 02:56:04 +00:00

profiler.rb

lib/profiler.rb: Specify frozen_string_literal: true.

2017-01-18 12:35:10 +00:00

pstore.rb

lib/pstore.rb: Specify frozen_string_literal: true.

2017-01-17 12:47:38 +00:00

rdoc.rb

Removed obsoleted test for RubyToken.

2017-10-10 04:54:49 +00:00

resolv-replace.rb

…

resolv.rb

resolv.rb: remove unnecessary require statement

2017-08-29 04:58:29 +00:00

rss.rb

…

rubygems.rb

Merge rubygems-2.6.14 changes.

2017-10-10 08:58:22 +00:00

scanf.gemspec

Update gemspec for gem released versions.

2017-09-14 02:01:36 +00:00

scanf.rb

…

securerandom.rb

lib/securerandom.rb: test one byte to determine urandom or openssl

2017-09-11 12:44:51 +00:00

set.rb

Alias Set#=== to #include?

2017-09-19 08:45:12 +00:00

shell.rb

shell.rb: suppress warnings

2016-11-05 23:58:02 +00:00

shellwords.rb

Fix the handling of the backslash in double quotes

2016-11-05 04:58:48 +00:00

singleton.rb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

sync.rb

…

tempfile.rb

tempfile.rb: do not call File.identical? on closed stream

2017-05-19 09:36:34 +00:00

thwait.rb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

time.rb

Time.parse's "now" argument as nil works again.

2016-11-05 14:03:34 +00:00

timeout.rb

…

tmpdir.rb

…

tracer.rb

Remove unnecessary require 'thread'

2017-10-08 07:00:01 +00:00

tsort.rb

…

un.rb

un.rb: use OpenSSL::PKey.read instead of OpenSSL::PKey::RSA.new

2017-07-05 09:05:53 +00:00

uri.rb

…

weakref.rb

[DOC] Use Integer instead of Fixnum [ci skip]

2017-01-26 15:14:02 +00:00

webrick.rb

…

yaml.rb

…