diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-11-29 17:51:00 +0300 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2025-11-29 14:18:23 -0600 |
| commit | e7839f773eef2072144fc858b4456aa346fcd665 (patch) | |
| tree | 22d8a843afb58541351d689790e80752a1e1a3b2 /drivers/remoteproc | |
| parent | 5e6fee736ee0d85acd74f955cab0110b15de4d11 (diff) | |
remoteproc: qcom: pas: Fix a couple NULL vs IS_ERR() bugs
The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers. Update the checking to match.
Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/0599691acc394d9390da8fa0b5de3399b132b187.1764427595.git.dan.carpenter@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Diffstat (limited to 'drivers/remoteproc')
| -rw-r--r-- | drivers/remoteproc/qcom_q6v5_pas.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 609df141ecb1..52680ac99589 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -559,9 +559,9 @@ static int qcom_pas_alloc_memory_region(struct qcom_pas *pas) pas->mem_phys = pas->mem_reloc = res.start; pas->mem_size = resource_size(&res); pas->mem_region = devm_ioremap_resource_wc(pas->dev, &res); - if (!pas->mem_region) { + if (IS_ERR(pas->mem_region)) { dev_err(pas->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(pas->mem_region); } if (!pas->dtb_pas_id) @@ -576,9 +576,9 @@ static int qcom_pas_alloc_memory_region(struct qcom_pas *pas) pas->dtb_mem_phys = pas->dtb_mem_reloc = res.start; pas->dtb_mem_size = resource_size(&res); pas->dtb_mem_region = devm_ioremap_resource_wc(pas->dev, &res); - if (!pas->dtb_mem_region) { + if (IS_ERR(pas->dtb_mem_region)) { dev_err(pas->dev, "unable to map dtb memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(pas->dtb_mem_region); } return 0; |