* Fix closures using FFI_REGISTER ABI
ffi_closure_REGISTER had the positions of the closure and return address
switched, resulting in a segfault when calling a closure created with
the FFI_REGISTER ABI.
* Fix comment and remove redundant assembly
* After fixing closures using FFI_REGISTER ABI, the comments were
incorrect, not reflecting the value that was actually loaded into eax
and ecx.
* Additionally, ecx was loaded with the data at esp + closure_FS only
to write it back to esp + closure_FS. Both commands were removed as
they end up not having any effect as ecx is overwritten during
FFI_CLOSURE_COPY_TRAMP_DATA.
The default code model of gcc for loongarch64 platform provides
256MiB PC-relative addressing space[1], which is not enough for
linking large binaries like chromium. Setting it to medium can
let libffi_pic.a get linked to large binaries successfully.
[1] https://github.com/loongson/la-abi-specs/blob/release/laelf.adoc#code_models
The .arch directive is only relevant for ELF targets, it is
unsupported for COFF and MachO targets.
Before 170bab47c90626a33cd08f2169034600cfd9589c, this was
not an issue as the directive was filtered out by the
ifndef __clang__.
Add static trampoline support to riscv32 and riscv64 Linux ABIs.
The implementation follows the s390x and powerpc implementations
which does not introduce a ffi_closure_*_alt function, but rather
jumps directly to the ffi_closure_asm function itself.
* src/wasm32: Allow building with Emscripten with 64bit support
MEMORY64 enables 64bit pointers so this commit updates the accessors for the
libffi data structures accordingly.
Each JS functions in ffi.c receives pointers as BigInt (i64) values and with
casts them to Numer (i53) using bigintToI53Checked. While memory64 supports
64bit addressing, the maximum memory size is currently limited to 16GiB
[1]. Therefore, we can assume that the passed pointers are within the
Number's range.
[1] https://webassembly.github.io/memory64/js-api/#limits
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
* Add wasm64 target to the build scripts
This commit adds support for the wasm64 target via the configure
script. Emscripten supports two modes of the -sMEMORY64 flag[1] so the
script allows users specifying the value through a configuration variable.
Additionally, "src/wasm32" directory has been renamed to the more generic
"src/wasm" because it's now shared between both 32bit and 64bit builds.
[1] https://emscripten.org/docs/tools_reference/settings_reference.html#memory64
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
* GitHub Actions: Add wasm64 tests
This commit adds a test matrix for wasm32, wasm64 and wasm64 with the
-sMEMORY64=2 flag, using the latest version of Emscripten. -Wno-main is
added to suppress the following warning in unwindtest.cc and
unwindtest_ffi_call.cc.
> FAIL: libffi.closures/unwindtest_ffi_call.cc -W -Wall -O2 (test for excess errors)
> Excess errors:
> ./libffi.closures/unwindtest_ffi_call.cc:20:5: warning: 'main' should not be 'extern "C"' [-Wmain]
> 20 | int main (void)
> | ^
> 1 warning generated.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
* testsuite: Fix types of main function
test_libffi.py calls each test's main function without arguments, but some
tests define the main function with parameters. This signature mismatch
causes a runtime error with the recent version of Emscripten.
This commit resolves this issue by updating the function signatures to match
the way they are called.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
* README: Add document about WASM64
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
---------
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Similar to PR #265 [1], we need to enable FFI_MMAP_EXEC_WRIT to use
explicit write+exec mapping on DragonFly BSD.
Without this fix, we were having segfaults with Meld [2]; it would crash
with SIGSEGV after 5 diff operations. The crash was caused by it
attempting to execute code from non-execute memory region. Moreover, if
we set the `machdep.pmap_nx_enable=2` tunable (i.e., strict NX mode),
Meld would crash upon the first diff operation.
Fix the `configure.ac` script to enable `FFI_MMAP_EXEC_WRIT` for
DragonFly BSD. In addition, add it to the supported platforms table.
[1] https://github.com/libffi/libffi/pull/265
[2] https://meldmerge.org/
* ci: add new build configuration in GitHub Actions
* ci: add Windows clang build workflow
* ci: add additional packages to GitHub workflows build
* ci: optimize build workflow and improve commenting
* ci: remove unused MSVC dev command from build workflow
* ci: modify build workflow to support multiple compilers
* build(github-actions): use matrix.compiler for CC and CXX variables
