67512 Commits

Author SHA1 Message Date
git
6095a4fec0 * 2021-09-01 [ci skip] 2021-09-01 09:16:16 +09:00
Stan Lo
fe7aaa94b4 Small grammar fixes 2021-09-01 09:15:57 +09:00
Nobuyoshi Nakada
d3155e3632 [ruby/zlib] Don't print out warnings when finalizing
https://github.com/ruby/zlib/commit/44a56d36e7
2021-08-31 23:20:42 +09:00
Nobuyoshi Nakada
31c427511c [ruby/zlib] Revert "Don't print out warnings when freeing."
https://github.com/ruby/zlib/commit/931aa7a272
2021-08-31 23:20:40 +09:00
Hiroshi SHIBATA
bfec03f5fe
Match parens for hidden files parenthetical
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2021-08-31 21:02:13 +09:00
S-H-GAMELINKS
a826747ade Remove unneeded comments in rational.c 2021-08-31 20:57:33 +09:00
universato
b6691e9737 Fix a code in the Array#min documentation. 2021-08-31 20:56:52 +09:00
David CARLIER
3ffca65047 addr2line: DragonFlyBSD build update.
same code path as FreeBSD's.
2021-08-31 20:52:49 +09:00
aycabta
9b188ac238 [ruby/reline] Remove one unnecessary nest for simplicity's sake
https://github.com/ruby/reline/commit/f4bda85a7c
2021-08-31 20:48:54 +09:00
aycabta
64373a3c58 Move access to dialog_render_info inside nil check 2021-08-31 20:35:10 +09:00
aycabta
a75f38431e Revert "Omit some tests until debugging is complete"
This reverts commit 3695d94b25f3e3e0d7a629bf1708ef421a51dd47.
2021-08-31 20:35:04 +09:00
jory-graham
db154b20cc [ruby/psych] Replace A-Za-z with [:alpha:]
https://github.com/ruby/psych/commit/8ec36494fb
2021-08-31 19:34:54 +09:00
Aaron Patterson
9ed2cb26de [ruby/psych] Add quotes to the strings "y" and "n"
'y' and 'n' are kind of ambiguous.  Syck treated y and n literals in
YAML documents as strings.  But this is not what the YAML 1.1 spec says.
YAML 1.1 says they should be treated as booleans.  When we're dumping
documents, we know it's a string, so adding quotes will eliminate the
"ambiguity" in the emitted document

Fixes #443

https://github.com/ruby/psych/commit/6a1c30634e
2021-08-31 19:34:46 +09:00
opak
0925fddc80 [ruby/psych] Update lib/psych/scalar_scanner.rb
https://github.com/ruby/psych/commit/64cc239557

Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
2021-08-31 19:34:36 +09:00
Alexandr Opak
44353d0dee [ruby/psych] add more tests
https://github.com/ruby/psych/commit/8f71222bf3
2021-08-31 19:34:28 +09:00
Alexandr Opak
beffa72c27 [ruby/psych] fix typo
https://github.com/ruby/psych/commit/ebb0cbded1
2021-08-31 19:34:21 +09:00
Alexandr Opak
48b50cb4fe [ruby/psych] fix parsing integer values with '_' at the end
https://github.com/ruby/psych/commit/e0bb853014
2021-08-31 19:34:13 +09:00
Tomer Brisker
31ba0921f8 [ruby/psych] Improve float scalar scanner
Previously, `+.inf` was not handled correctly. Additionally, the regexp
was checking for inf and NaN, even though these cases are handled earlier
in the condition. Added a few tests to ensure handling some missing
cases.

https://github.com/ruby/psych/commit/6e0e7a1e9f
2021-08-31 19:34:06 +09:00
Samuel Williams
d19af1675c [ruby/zlib] Don't print out warnings when freeing.
https://github.com/ruby/zlib/commit/098c50255d
2021-08-31 19:33:38 +09:00
Nobuyoshi Nakada
41867532ac
No commits to pick is success [ci skip] 2021-08-31 19:07:08 +09:00
David Rodríguez
f315be2615 [rubygems/rubygems] Remove dead code
https://github.com/rubygems/rubygems/commit/9978b787a0
2021-08-31 19:06:14 +09:00
David Rodríguez
4bc87cb1fb [rubygems/rubygems] Remove syck traces from bundler
Same reason as in the previous commit.

https://github.com/rubygems/rubygems/commit/f00a6c8516
2021-08-31 19:06:14 +09:00
David Rodríguez
1e290c31f4 [rubygems/rubygems] Merge Gem::UriParser and Gem::PrintableUri into a Gem::Uri class
The new class is a wrapper on top of an URI. And then, when you want
credentials redacted, you call `#redacted` that returns a copy of itself,
but with credentials redacted.

https://github.com/rubygems/rubygems/commit/9581c2740a
2021-08-31 19:06:14 +09:00
David Rodríguez
f0c6cc14b1 [rubygems/rubygems] Make sure Gem::Command is available before using it
https://github.com/rubygems/rubygems/commit/95326f827c
2021-08-31 19:06:14 +09:00
David Rodríguez
41240ffee3 [rubygems/rubygems] Remove unused require
https://github.com/rubygems/rubygems/commit/2ee3e78a7a
2021-08-31 19:06:14 +09:00
Keiko Kaneko
e841042070 [rubygems/rubygems] Add missing key branches:
ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags

Running jobs with only branch name, without `branches:`, CI fails

https://github.com/rubygems/rubygems/commit/fcec167d61
2021-08-31 19:06:14 +09:00
Daniel Niknam
ceba866864 [rubygems/rubygems] Remove unnecessary tests
We will be passing string to this class so there is no need to be defensive about it.

https://github.com/rubygems/rubygems/commit/30bd52a977
2021-08-31 19:06:14 +09:00
Daniel Niknam
1948ac20ce [rubygems/rubygems] Replacing clone with dup
https://github.com/rubygems/rubygems/commit/30f5b3c027
2021-08-31 19:06:14 +09:00
Daniel Niknam
4715bbf7b3 [rubygems/rubygems] Remove returning self for Gem::PrintableUri#parse_uri
https://github.com/rubygems/rubygems/commit/25c99d7f9d
2021-08-31 19:06:14 +09:00
Daniel Niknam
aa898b4206 [rubygems/rubygems] Remove @credential_redacted instance variable
https://github.com/rubygems/rubygems/commit/c3bb52eb5c
2021-08-31 19:06:14 +09:00
Daniel Niknam
7067005f23 [rubygems/rubygems] Bring back the empty line that was removed previously by mistake
https://github.com/rubygems/rubygems/commit/ffb480ca7a
2021-08-31 19:06:14 +09:00
Daniel Niknam
d73dc8e937 [rubygems/rubygems] Remove unused method
https://github.com/rubygems/rubygems/commit/3a8486794e
2021-08-31 19:06:14 +09:00
Daniel Niknam
6d883b33ae [rubygems/rubygems] Remove ruby/uri requirement
For the purpose of this class, we need to make sure the return object by `Gem::UriParser.parse_uri` method will have the following method:
- user
- user=
- password
- password=
So we  can remove the the `uri` dependency and just look for the methods to exist.

https://github.com/rubygems/rubygems/commit/241e093597
2021-08-31 19:06:14 +09:00
Daniel Niknam
589377fbdc [rubygems/rubygems] Refactor Gem::RemoteFetcher::FetchError.build back to its initialize method
https://github.com/rubygems/rubygems/commit/21dcdd2dc5
2021-08-31 19:06:14 +09:00
Daniel Niknam
a508693f06 [rubygems/rubygems] Remove defensive guards
https://github.com/rubygems/rubygems/commit/dba130cd80
2021-08-31 19:06:14 +09:00
Daniel Niknam
fafd9d280a [rubygems/rubygems] Rename Gem::PrintableUri#parsed_uri? to Gem::PrintableUri#valid_uri?
https://github.com/rubygems/rubygems/commit/a5177709c9
2021-08-31 19:06:14 +09:00
Daniel Niknam
e3c319ad53 [rubygems/rubygems] Remove trailing if
https://github.com/rubygems/rubygems/commit/5b6b649bba
2021-08-31 19:06:14 +09:00
Daniel Niknam
3adc141a79 [rubygems/rubygems] Refactor Gem::RemoteFetcher::FetchError initializer to build method
The `initialize` method is already doing a lot and by adding the `Gem::PrintableUri` to redact sensitive information, things are getting complicated and hard to read here. For the start, I have refactored the `initialize` method into a class method called `build`.

https://github.com/rubygems/rubygems/commit/4312e8fdf5
2021-08-31 19:06:14 +09:00
Daniel Niknam
19e1d3cdce [rubygems/rubygems] Using Gem::PrintableUri in Gem::Request class
The `@uri` variable could be a source URI with a credential. Using `Gem::PrintableUri` to make sure we are redacting sensitive information from it when logging on verbose mode.

https://github.com/rubygems/rubygems/commit/f566787211
2021-08-31 19:06:14 +09:00
Daniel Niknam
31c2e6c08e [rubygems/rubygems] Using Gem::PrintableUri in Gem::Commands::InstallCommand class
The `x.source.uri` could be a source URI with a credential. Using `Gem::PrintableUri` to make sure we are redacting sensitive information from it.

https://github.com/rubygems/rubygems/commit/8755ee0aaa
2021-08-31 19:06:14 +09:00
Daniel Niknam
b41802421a [rubygems/rubygems] Introduce Gem::PrintableUri that would redact URIs to be used on outputs
We need to redact URI credential in several places and copy pasting the code into each part of it is not ideal. This class is responsible for parsing URI strings and redacting credential from it. Also, it will handle URI object in the same manner. We will be reusing this class whenever we need to print/display a URI to users.
URI with the following format will be redacted:
- Token: `http://my-secure-token@example.com` => `http://REDACTED@example.com`
- Username & Password: `http://my-username:my-secure-password@example.com` => `http://my-username:REDACTED@example.com`
- x-oauth-basic: `http://my-secure-token:x-oauth-basic@example.com` => `http://REDACTED:x-oauth-basic@example.com`

https://github.com/rubygems/rubygems/commit/f1e45d3a89
2021-08-31 19:06:14 +09:00
Daniel Niknam
14a9e24f7e [rubygems/rubygems] Add a few tests for Gem::UriParser.parse_uri
https://github.com/rubygems/rubygems/commit/1ea73df161
2021-08-31 19:06:14 +09:00
Matt Larraz
5f205073d2 [rubygems/rubygems] Pass second argument to Array#split to ensure only two values returned
https://github.com/rubygems/rubygems/commit/601b5553bb
2021-08-31 19:06:14 +09:00
David Rodríguez
c119dd2b5a [rubygems/rubygems] Fix bundle plugin install misdetection of installed versions
https://github.com/rubygems/rubygems/commit/9c88db949d
2021-08-31 19:06:14 +09:00
David Rodríguez
c044f818ca [rubygems/rubygems] Move Bundler.rubygems.clear_paths to a better place
Since it clears both home and path.

https://github.com/rubygems/rubygems/commit/fadf5e03ea
2021-08-31 19:06:14 +09:00
David Rodríguez
8c79486e7e [rubygems/rubygems] Bundle path is already expanded
https://github.com/rubygems/rubygems/commit/a296052670
2021-08-31 19:06:14 +09:00
David Rodríguez
71b937d3d7 [rubygems/rubygems] Normalize setting GEM_PATH
https://github.com/rubygems/rubygems/commit/4188ebd568
2021-08-31 19:06:14 +09:00
David Rodríguez
d0da3a2a7f [rubygems/rubygems] Remove more unused code
https://github.com/rubygems/rubygems/commit/986e889a79
2021-08-31 19:06:14 +09:00
David Rodríguez
8d32f46d04 [rubygems/rubygems] Remove unnecessary line
https://github.com/rubygems/rubygems/commit/a7023c6c21
2021-08-31 19:06:14 +09:00
David Rodríguez
f934096638 [rubygems/rubygems] Make plugin installation idempotent
The error had not be caught be specs because `bundle install` was
returning a zero exit code when plugin installation errors happened. So
I fixed that issue too.

https://github.com/rubygems/rubygems/commit/90cde87856
2021-08-31 19:06:14 +09:00